ramapcsx2 / gbs-control

GNU General Public License v3.0
793 stars 111 forks source link

Fix auto gain on passthrough, properly preserve or reset gain when loading new presets #459

Closed nyanpasu64 closed 1 year ago

nyanpasu64 commented 1 year ago

Tentative test cases:

And:

(All verified on Wii 480p input, as of commit fc6acc109fb2bd54941be9127562e8da01d69eb5.)

Fixes

Unresolved questions

I'm getting sporadic black screen flashes (so far Super Monkey Ball 2 and Mario Kart Wii, with 480p pixel fix enabled but ineffective) when playing Wii in 480p, with this PR in custom passthrough mode with auto gain enabled. I don't currently know what configurations cause this problem to appear or not.

nyanpasu64 commented 1 year ago

i might've just seen my wii lose sync out the corner of my eye, with auto gain off.

i don't know what's wrong. i don't care anymore. maybe my hardware is defective, i'm waiting for my SoG capacitors to arrive. this change is undisputably a bugfix, and will be merged.