search

ramapcsx2 / gbs-control

GNU General Public License v3.0
771 stars 110 forks source link

Added remove presets feature #496

Closed AlivE-git closed 7 months ago

AlivE-git commented 10 months ago

image

nyanpasu64 commented 9 months ago

I'm happy to see this functionality be added!

Didn't see this before, don't have time to do a full inspection right now, but perhaps extract the string literal used in slotIndexMap to a global so it can't go out of sync between the two functions?

(Though it can still go out of sync with getSlotsHTML in webui.html, but this isn't really avoidable (though I still kinda want to turn the array in getSlotsHTML into a string literal, so you can identify that those character sequences match by grepping, which isn't currently possible).

Did you test that the preset button layout works on desktop and mobile (narrow window width), with and without developer mode enabled?

ramapcsx2 commented 9 months ago

Oh, same! Would be great to add, maybe just do your fix and shipit, @nyanpasu64 ? :)

AlivE-git commented 9 months ago

Fixed :) I also checked button layout, there are no problems.

YoImLee commented 7 months ago

I'd love to see this being merged. It seems to work well on my personal gbs.

ramapcsx2 commented 7 months ago

Okay, here goes nothing!

Metaln00b commented 5 months ago

@AlivE-git Can you please also add your changes to the files in the gbs-control/public/src/ (index.ts etc.) folder? Unfortunately, your feature is removed again after the npm install and npm run build. The files you have edited are generated files, if I have understood correctly.