ramapcsx2 / gbs-control

GNU General Public License v3.0
771 stars 110 forks source link

Add platformio support #505

Closed Metaln00b closed 5 months ago

Metaln00b commented 8 months ago

Currently not fully tested platformio version of gbs-control Build with warnings about SPIFFS (deprecated)

image v2 Lower Memory (default)

Fixed #504

Metaln00b commented 8 months ago

Seems to be working except:

image

Reconnecting to /dev/ttyUSB1 ..  Connected!
(WiFi): AP mode (SSID: gbscontrol, pass 'qqqqqqqq'): Access 'gbscontrol.local' in your browser
no ext clockgen
<reset>
Chip ID: 1A 1
 G: 3E G: 3F G: 40 G: 41 G: 42
 R: 3E R: 3F R: 40 R: 41
 B: 3E B: 3F B: 40 B: 41 B: 42 B: 43 B: 44
<reset>
Activity detected, input: Component

2345678
Format change: 2 <stable>
matched preset override > 1280x1024
ADC offset: R:41 G:42 B:44
HTotal Adjust: -9, source Hz: 49.998, output Hz: 50.011

preset applied: 1280x1024 for PAL 50Hz 

I need help :D

Fixed: There was a wrong flash build_flag

ramapcsx2 commented 8 months ago

So, I'm not sure what to say here.. You know that I don't actively work on gbsc because of other projects, right? This makes it difficult to judge the impact of big platform affecting PRs like this. Things need to be tested, there are other coders active that need to verifiy it works for them, etc pp. Is this worth the effort? I wonder.. Plattformio is an alternative to more vanilla Arduino, but I haven't heard people using it much lately.

Any other's opinion? @nyanpasu64 ? :)

nyanpasu64 commented 8 months ago

sorry i'm not working actively on (editing) gbs-c right now. I tried porting GBS-C to platformio once in the past, don't remember if I got it working or ran into obstacles. I don't know whether I want to merge a change to the mainline repo, that breaks existing build systems.

If you want, you can fork the project and maintain it yourself, and see if the changes result in a better build/runtime experience.

Plattformio is an alternative to more vanilla Arduino, but I haven't heard people using it much lately.

In terms of other projects using PlatformIO or not, https://github.com/OpenStickCommunity/GP2040-CE vendors their libraries, https://github.com/JonnyHaystack/HayBox uses platformio I think? I'd say the library management is probably better than Arduino's global libraries or vendoring (at least for supported libraries).

In terms of less positive vibes from the company, https://github.com/platformio/platform-raspberrypi/pull/36#issuecomment-1673289374 platformio seems to be demanding that Raspberry Pi pay them money before they'll merge a Pi Pico PR not by the Raspberry Pi company.

maxgerhardt makes it clear that an RPI exec has recently privately contacted them to try to urge this PR getting merged. ivankravets responds implicating RPI in using the community to surreptitiously avoid licensing fees. Eben Upton joins the thread stating that PIO had approached them with a proposal seeking licensing fees in Oct, 2022 and they walked away from it without negotiations. Notably, this is months after this PR was already in a mergeable state.

🤔 idk. tbh I think we should work out whether it's technically a good idea first (does it require users install VSCode PlatformIO to build the project?).

ramapcsx2 commented 8 months ago

Thanks for you thoughts, @nyanpasu64.