ramapcsx2 / gbs-control

GNU General Public License v3.0
771 stars 110 forks source link

OLED screen - Line Filter toggle #553

Open golimonkey opened 1 month ago

golimonkey commented 1 month ago

I often toggle line filter depending on what console I connect to GBSC and changeing profiles with OLED menu works good but linefilter setting doesnt change. I tried enableing Save filtering per slot option but it doesnt work with oled menu. Could someone add linefilter toggle in OLED menu somewhere? I tried to do it myself but cant understand the code properly.

Sorry if request is inappropriate.

ramapcsx2 commented 1 month ago

Hey ho, it's appropriate, of course. I don't have time for it, but this request serves perfectly to show @way5 how these feature requests formed the messy preset system :p Since he's currently overhauling it, maybe he can fit this in.

way5 commented 1 month ago

@ramapcsx2 yeah, I've already seen that fuzzy logic. I am doing some testing, after changing way too many things. There is no way someone do something with it without changing everything :)

@golimonkey I can not promise for sure :) but I'll try to do something similar to what you've mentioned.

way5 commented 4 weeks ago

Hey @golimonkey ! Just FYI, line filter control seems to work properly in 'pio' branch through WebUI. So if you're comfortable with uploading the new firmware onto your GBSC, I'd recommend you to try. 😉 See the How To in README. ref: #551

golimonkey commented 4 weeks ago

@way5 Ty for your info, I will try 'pio' branch! But I'll still be looking forward for your implementation on OLED menu.

way5 commented 3 weeks ago

Hi @golimonkey I hasten to inform there is an update you requested in pio branch. I expect to have a feedback from you on that update. 😉

golimonkey commented 2 weeks ago

@way5 Great news. I'll get back to you. Flashing it today.

golimonkey commented 2 weeks ago

@way5 Hi. Tried it just now but cant compile pio branch. I get errors with missing heather files, tried to fix it by editing paths but didnt manage. Not enough time and very little expirience working on other peoples projects...

Error: sketch\src/wserial.h:16:30: fatal error: WebSocketsServer.h: No such file or directory

include

It may very well be that its my fault. I downloaded zip(gbs-control-pio), renamed it to gbs-control and tried to compile with arduinoIDE. That works with main branch for me.

Let me know if there is something that I'm missing, probably project isn't set up correctly.

ramapcsx2 commented 2 weeks ago

@golimonkey The branch is being developed using PlatformIO, which is a more advanced environment than pure Arduino. If something doesn't work, you may have to install that. Toolchains and SDKs man, it's the coder's life :p

golimonkey commented 2 weeks ago

Tnx @ramapcsx2, it try in in VM then.

ramapcsx2 commented 2 weeks ago

No promises though, but it's worth a try :p

way5 commented 2 weeks ago

@way5 Hi. Tried it just now but cant compile pio branch. I get errors with missing heather files, tried to fix it by editing paths but didnt manage. Not enough time and very little expirience working on other peoples projects...

Error: sketch\src/wserial.h:16:30: fatal error: WebSocketsServer.h: No such file or directory

include

It may very well be that its my fault. I downloaded zip(gbs-control-pio), renamed it to gbs-control and tried to compile with arduinoIDE. That works with main branch for me.

Let me know if there is something that I'm missing, probably project isn't set up correctly.

Please read README.md in "pio" branch. This says you need to install all required libraries and remove main.cpp if you compile using Arduino IDE.

You can install it using ANY of this two IDEs, however there is more work when you use Arduino.

--- UPD:

@golimonkey there is easy way using VSCode and its PlatformIO plugin. Just install it on any OS you working on and open the project directory, VSCode will do the rest. All necessary info is in README

Keep in mind that this must be a clean install, so you should erase the chip, the upload Firmware and Filesystem.

golimonkey commented 2 weeks ago

@way5 Ty for instructions. I think I'll be able to do it now.

I have two diy GBSC-s so I'll keep pio branch on one for testing.

IMG_20240616_013846