ramapriyan912001 / pe

0 stars 0 forks source link

Inconsistency in highlights of class names #16

Open ramapriyan912001 opened 3 years ago

ramapriyan912001 commented 3 years ago

Screenshot 2021-11-12 at 5.28.52 PM.png

Lack of consistency with highlights. Every other class name mentioned is highlighted, why not Index?

nus-pe-bot commented 3 years ago

Team's Response

In this section, all the classes that were shown in the sequence diagram above these steps have their names highlighted in the steps. Index does not appear in the above sequence diagram, so to keep it consistent we decided not to highlight "Index".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since this is an argument about some kind of heuristic followed throughout the DG, I am going to take screenshots from the DG to disprove the notion that this was a heuristic held throughout its composition. Note that, for this to be a genuine heuristic, I would suppose that this same logic should stretch to all diagrams. Only terms mentioned in the diagrams are to be highlighted, claims the team.

"if a term is highlighted, it was mentioned in the diagram" - statement to disprove.

However, in the example below, there is no mention of an internshipStateList, yet it is highlighted. Screenshot 2021-11-17 at 8.54.30 AM.png

Here is an instance where 2 classes are highlighted, with no diagram around with that mentions them. Screenshot 2021-11-17 at 9.00.32 AM.png

There are more such examples, but just to illustrate, this is an invalid argument as this heuristic is not followed