search

ramapriyan912001 / pe

0 stars 0 forks source link

Case sensitivity in add command for company prefix #2

Open ramapriyan912001 opened 3 years ago

ramapriyan912001 commented 3 years ago

I entered these commands in the following order: -

  1. add c/JP Morgan p/banker d/2021-12-29
  2. add c/jp morgan p/banker d/2021-12-29

Screenshot 2021-11-12 at 4.23.52 PM.png

I think this is of medium severity as it could lead to a person seeing many duplicates of the same deadline and cause them unnecessary stress and extra work.

nus-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitive company name

Steps to reproduce:

  1. type command add c/shopee p/software engineer d/2021-12-12 r/resume i/2021-12-20 0830
  2. new entry is added even though the name shop and position are the same as an existing entry

Expected behaviour: name and position should be case insensitive since your UG states that adding an entry with same company name and position is not allowed.

Actual behaviour: new entry is added even though the name shop and position are the same as an existing entry

image.png

[original: nus-cs2103-AY2122S1/pe-interim#5300] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Indeed, we acknowledge that duplicate detection should be incorporated into our design, as the it's very likely that Amazon and amazon refers to the same company. However, this is supposed to be a FeatureFlaw instead of FunctionalityBug, and since this is more related to NFR of the product, it should be of a lower severity level.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: The central purpose of your product is to reduce the stress of individuals and make sure that they feel more at ease when going through the internship cycle.

This bug very fundamentally undermines that purpose. Duplicates mean that individuals will believe that they have significantly more to do than they actually do, and that means elevated levels of stress and anxiety which this product claims to solve.

As such, I believe the severity of this bug is Medium.