search

ramapriyan912001 / pe

0 stars 0 forks source link

Case sensitivity for p/ tag in add command #3

Open ramapriyan912001 opened 2 years ago

ramapriyan912001 commented 2 years ago

Entered commands in following order:

  1. add c/bank p/banker d/2021-12-29
  2. add c/bank p/Banker d/2021-12-29

Allowing duplicates like this is problematic because it appears to the user that they have more things to do than they actually do. The goal of the app is to lessen the burden on the user, and this would lead to the right opposite of that. As such, this is a medium severity bug.

Screenshot 2021-11-12 at 4.27.26 PM.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitive company name

Steps to reproduce:

  1. type command add c/shopee p/software engineer d/2021-12-12 r/resume i/2021-12-20 0830
  2. new entry is added even though the name shop and position are the same as an existing entry

Expected behaviour: name and position should be case insensitive since your UG states that adding an entry with same company name and position is not allowed.

Actual behaviour: new entry is added even though the name shop and position are the same as an existing entry

image.png

[original: nus-cs2103-AY2122S1/pe-interim#5300] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Indeed, we acknowledge that duplicate detection should be incorporated into our design, as the it's very likely that Amazon and amazon refers to the same company. However, this is supposed to be a FeatureFlaw instead of FunctionalityBug, and since this is more related to NFR of the product, it should be of a lower severity level.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: In CS2103 documentation, a duplicate is claimed to be 2 bugs that can be solved by a single change. However, this isn't the case here. Position and Company are two different entities. If you look into their codebase, which I only did AFTER the exam, you will find that there are two separate classes. A Position class and a Company class. By the letter of the law stated in the CS2103 website, given both case sensitivity issues cannot be solved with a change in a single location, it is apparent to me that this cannot be regarded a duplicate bug.

These can only be fixed independently, not together. By the letter of the law, as stated in the website, this is not a duplicate bug. While I sympathise with the team, given the rules under which we are undertaking this examination, these are clearly separate bugs.

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: The central purpose of your product is to reduce the stress of individuals and make sure that they feel more at ease when going through the internship cycle.

This bug very fundamentally undermines that purpose. Duplicates mean that individuals will believe that they have significantly more to do than they actually do, and that means elevated levels of stress and anxiety which this product claims to solve.

As such, I believe the severity of this bug is Medium.