Open ramapriyan912001 opened 2 years ago
This issue is related to duplicate detection and hence we regard this as a duplicate of issue 5301 as specified in the module website under bug triaging.
[The team marked this bug as a duplicate of the following bug]
Case sensitive company name
Steps to reproduce:
- type command add c/shopee p/software engineer d/2021-12-12 r/resume i/2021-12-20 0830
- new entry is added even though the name shop and position are the same as an existing entry
Expected behaviour: name and position should be case insensitive since your UG states that adding an entry with same company name and position is not allowed.
Actual behaviour: new entry is added even though the name shop and position are the same as an existing entry
[original: nus-cs2103-AY2122S1/pe-interim#5300] [original labels: type.FunctionalityBug severity.Medium]
[This is the team's response to the above 'original' bug]
Indeed, we acknowledge that duplicate detection should be incorporated into our design, as the it's very likely that
Amazon
andamazon
refers to the same company. However, this is supposed to be aFeatureFlaw
instead ofFunctionalityBug
, and since this is more related to NFR of the product, it should be of a lower severity level.
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: These can only be fixed independently, not together.
I argue that whitespace detection and case sensitivity are two aspects that can be fixed independently.
If I were to check for casing, I would have to use some kind of .lower()
function. This would not solve my whitespace issue.
If I were to check for whitespaces, I would have to use some kind of trim()
function. This would not solve my casing issue.
By the letter of the law, as stated in the website, this is not a duplicate bug. While I sympathise with the team, given the rules under which we are undertaking this examination, these are clearly separate bugs.
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: The central purpose of your product is to reduce the stress of individuals and make sure that they feel more at ease when going through the internship cycle.
This bug very fundamentally undermines that purpose. Duplicates mean that individuals will believe that they have significantly more to do than they actually do, and that means elevated levels of stress and anxiety which this product claims to solve.
Furthermore, what if the individual schedules his/her time the wrong way based on the increased number of entries in the app? This would lead to compromised outcomes for their other internships due to a lack of appropriate time allocation.
Given the fact that this undermines the purpose of the app, and can have adverse outcomes, I believe this is a Medium bug.
As such, I believe the severity of this bug is Medium.
Following commands in order were entered, and permitted.
add c/bank of america p/position d/2021-12-29 add c/bank of america p/position d/2021-12-29
Duplicates issue again, causing stress on user.