> I think we should rename both algorithms to have the dash as they are
> specified as such in JCE reference [2]. This will change lines 39 and
> 40 to read:
> public static final String H_ALGORITHM_SHA1 = "SHA-1";
> public static final String H_ALGORITHM_SHA256 = "SHA-256";
I saw that you made the change already, that's great.
> I've tested this against a fresh JDK 1.5 and 1.6. Also, the build now
> gets the green light on the build server :) [3]
We should also test against JDK 1.4.
> These changes should be cool with Bouncy Castle's JCE, as they seem
> more lenient than Sun's implementation. We also won't need to include
> JCE providers as a part of our distribution, so no need to worry about
> the legal aspects of shipping crypto libs.
Yes, that is a nice side effect. We should also document both
procedures, installing the policy file or installing an alternate JCE
library.
http://groups.google.com/group/openid4java/browse_thread/thread/
9503e06477e84a6/196c353973b92469?lnk=gst&rnum=1#196c353973b92469
Original issue reported on code.google.com by Johnny.B...@gmail.com on 19 May 2007 at 7:42
Original issue reported on code.google.com by
Johnny.B...@gmail.com
on 19 May 2007 at 7:42