search

ramarao9 / AttachmentUploader

A Power App code component to easily upload one or more attachments on Dynamics365 records.
MIT License
16 stars 9 forks source link

The code generator has optimized the styling of [path] as it exceeds the max of 500KB. #11

Closed phanimandapati closed 4 years ago

phanimandapati commented 4 years ago

Hi Rama,

Can you please help us with resolving the issue [The code generator has optimized the styling of [path] as it exceeds the max of 500KB. ]. We are facing this for ReactDOM file. Since we need to customize as per our requirement. We can't use the existing solution file. Can you please help us resolving this issue, which will be of great help to us. Capture

ramarao9 commented 4 years ago

Hi Phani,

I will take a look and get back to you on this.

Could you provide me the steps to reproduce this or how you are customizing it on your end so I can mimic the behavior?

Thanks

phanimandapati commented 4 years ago

Hi Ram,

Thanks for your reply. We are going to use different entity in place of attachment entity. Once we drop the file it should create record of that entity. So we were planning to use the existing source code instead of using solution file. But when we tried to built existing source code we got the below issue. We didn't make any changes, just straight away tried to build it without changes in code.

Thanks & Regards Phani

On Tue, 18 Aug, 2020, 8:48 pm Rama Rao Koneru, notifications@github.com wrote:

Hi Phani,

I will take a look and get back to you on this.

Could you provide me the steps to reproduce this or how you are customizing it on your end so I can mimic the behavior?

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#issuecomment-675542556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPJHUIVOJOLR535CL5TSBKLURANCNFSM4QDMGQUQ .

ramarao9 commented 4 years ago

@phanimandapati Looks like this usually happens with Babel but it should not cause issues with generating the build. You can turn off the warning as described here

Below is an example of how it generates the build outputs for me when I do npm run build image

Did you also run the below commands after building the PCF component to generate the solution files?

Note: msbuild /t:build /restore is only needed for the first time to build the solution project by pulling down the NuGet dependencies as part of the restore. The second time and going forward you can just do msbuild to generate the solution files.

image

When updating the versions for subsequent builds you would need to change it in the below places before creating a build and generating the solution files

phanimandapati commented 4 years ago

Hi Ram,

Well I did try to use npm start to see UI part in wep page but I didn't see anything, I will try to build solution and test it.

Thanks, Phani

On Wed, 19 Aug, 2020, 8:37 am Rama Rao Koneru, notifications@github.com wrote:

@phanimandapati https://github.com/phanimandapati Looks like this usually happens with Babel but it should not cause issues with generating the build. You can turn off the warning as described here https://stackoverflow.com/questions/35192796/babel-note-the-code-generator-has-deoptimised-the-styling-of-app-js-as-it-exc/36880182

Below is an example of how it generates the build outputs for me when I do npm run build [image: image] https://user-images.githubusercontent.com/37280856/90585715-17945900-e19b-11ea-987d-36b36e13a951.png

Did you also run the below commands after building the PCF component to generate the solution files?

Note: msbuild /t:build /restore is only needed for the first time to build the solution project by pulling down the NuGet dependencies as part of the restore. The second time and going forward you can just do msbuild to generate the solution files.

[image: image] https://user-images.githubusercontent.com/37280856/90586553-1532fe80-e19d-11ea-99ea-b240e60c8ff6.png

When updating the versions for subsequent builds you would need to change it in the below places before creating a build and generating the solution files

  • Navigate to /AttachmentUpload/ControlManifest.Input.xml and update the version on the control. This is an internal version used by the Power Platform to look for changes in the component.
  • Navigate to /AttachmentDragandDrop/Other/Solution.xml and update the version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#issuecomment-675824704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPO4QBTYVVN6KWTBVO3SBM6YPANCNFSM4QDMGQUQ .

ramarao9 commented 4 years ago

So you do not see the below when doing npm run start?

image

Can you send me a screenshot of what happens after the message 'The code generator....'?

phanimandapati commented 4 years ago

I did see it, but couldn't check the UI part in webpage. Well I tried checking the compact part "pipe(babel({compact" and it's subsets but I found nothing in the whole solution files. So i couldn't place the false part. Well I think I better deploy control to D365 and check it directly.

I will be working on my actual requirements today. Very greatful for your support. If I face further challenges I will try to contact you. Please close the issue.

Thanks, Phani

On Wed, 19 Aug, 2020, 8:45 am Rama Rao Koneru, notifications@github.com wrote:

So you do not see the below when doing npm run start?

[image: image] https://user-images.githubusercontent.com/37280856/90587926-144f9c00-e1a0-11ea-8461-30e407948a8d.png

Can you send me a screenshot of what happens after the message 'The code generator....'?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#issuecomment-675826552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPOCDAQ7I5Y67BEQIF3SBM7TLANCNFSM4QDMGQUQ .

ramarao9 commented 4 years ago

I see, that makes sense now. Initially when the control is written there wasn't an easy way to test it in the UI other than tweaking the index.ts file and putting in fake data. So nothing renders locally until it has the necessary context it's looking for.

You could still do that by manipulating certain methods in the index file. Not sure if there have been any recent changes that would allow easier testing. Something I have on my list to look.

No problem!

phanimandapati commented 4 years ago

Hi Ram,

Small query requirement has to use custom entity in place of attachment entity is that scenario possible in pcf. Cause when we drop attachment into pcf control, it should be added in same way how it's done with attachment entity. I tried creating activity entity and made changes but count replicate the same.

Kindly provide me your valuable suggestions. That would be of great help.

If possible can you share me your whatsapp number. For better communication, if you don't mind.

Thanks & Regards Phani

On Wed, 19 Aug, 2020, 9:06 am Rama Rao Koneru, notifications@github.com wrote:

Closed #11 https://github.com/ramarao9/AttachmentUploader/issues/11.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#event-3668916647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPMDBESN7IZA7Q6C4U3SBNCFJANCNFSM4QDMGQUQ .

ramarao9 commented 4 years ago

So you created a custom activity entity and trying to use that to upload attachments? If that's the case the code currently only accepts email and appointment. Let me know and I can run some tests to see if it can be fixed to allow any activity entity including custom activity.

phanimandapati commented 4 years ago

Hi Ram,

We need to add lookup and few fields to notes entity, but I think it's not possible to add fields to notes entity right. Do you know anyways to do that. If not we have to go with custom entity and make use of it to work like notes entity.

Please let me know if you have any solution as such.

Thanks Raju

On Sun, 23 Aug, 2020, 6:46 am Rama Rao Koneru, notifications@github.com wrote:

Reopened #11 https://github.com/ramarao9/AttachmentUploader/issues/11.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#event-3682440567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPKJQDUGMIWDHE3Q6TLSCBUW7ANCNFSM4QDMGQUQ .

phanimandapati commented 4 years ago

Hi Rama,

I created a custom entity named fcpm_fileattachment(activity entity), I have made the changes below in order to create a record in a custom entity.

[image: image.png]

But i am facing the below error, when i dropped the attachment.

[image: image.png]

Can you please help me resolve this issue?

Thanks, raju

On Wed, Aug 26, 2020 at 12:29 PM Raju Mandapati rajuoutlier@gmail.com wrote:

Hi Ram,

We need to add lookup and few fields to notes entity, but I think it's not possible to add fields to notes entity right. Do you know anyways to do that. If not we have to go with custom entity and make use of it to work like notes entity.

Please let me know if you have any solution as such.

Thanks Raju

On Sun, 23 Aug, 2020, 6:46 am Rama Rao Koneru, notifications@github.com wrote:

Reopened #11 https://github.com/ramarao9/AttachmentUploader/issues/11.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#event-3682440567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPKJQDUGMIWDHE3Q6TLSCBUW7ANCNFSM4QDMGQUQ .

phanimandapati commented 4 years ago

Got fixed

On Wed, 26 Aug, 2020, 7:15 pm Raju Mandapati, rajuoutlier@gmail.com wrote:

Hi Rama,

I created a custom entity named fcpm_fileattachment(activity entity), I have made the changes below in order to create a record in a custom entity.

[image: image.png]

But i am facing the below error, when i dropped the attachment.

[image: image.png]

Can you please help me resolve this issue?

Thanks, raju

On Wed, Aug 26, 2020 at 12:29 PM Raju Mandapati rajuoutlier@gmail.com wrote:

Hi Ram,

We need to add lookup and few fields to notes entity, but I think it's not possible to add fields to notes entity right. Do you know anyways to do that. If not we have to go with custom entity and make use of it to work like notes entity.

Please let me know if you have any solution as such.

Thanks Raju

On Sun, 23 Aug, 2020, 6:46 am Rama Rao Koneru, notifications@github.com wrote:

Reopened #11 https://github.com/ramarao9/AttachmentUploader/issues/11.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramarao9/AttachmentUploader/issues/11#event-3682440567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXPRPKJQDUGMIWDHE3Q6TLSCBUW7ANCNFSM4QDMGQUQ .

ramarao9 commented 4 years ago

@phanimandapati I did run a test on custom activity entity and was able to add attachments as expected. I was not able to see your screenshots above but glad you got it resolved. Closing the issue at this time.