search

ramasilveyra / gitpkg

Publish packages as git tags
MIT License
274 stars 27 forks source link

fix(git-tag-name): npm5 has issues with git tags with @ and / chars #1

Closed ramasilveyra closed 7 years ago

ramasilveyra commented 7 years ago

npm5 has issues with git tags with @ and / chars.

NOTE: this doesn't happen with npm 3

codecov-io commented 7 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   54.76%   54.76%           
=======================================
  Files          17       17           
  Lines         126      126           
  Branches       16       16           
=======================================
  Hits           69       69           
  Misses         55       55           
  Partials        2        2
Impacted Files Coverage Δ
src/tasks/Publish/normalise-package-name.js 100% <ø> (ø) :arrow_up:
src/tasks/Publish/get-git-tag-name.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7408a80...8fbf6d0. Read the comment docs.