Add support for custom git tags

ramasilveyra / gitpkg

Publish packages as git tags

MIT License

274 stars 28 forks source link

Add support for custom git tags #17

Closed thejsn closed 4 years ago

thejsn commented 4 years ago

This adds support for custom git tags through an optional gitpkg.config.js file. Possibly fixes #16 too

ramasilveyra commented 4 years ago

This is looking great! I think that I don't mind dropping support for node v6 and releasing this as a breaking change. I will take a deep look during this week. Thanks!

thejsn commented 4 years ago

@ramasilveyra Thanks for having a look! I was a bit confused why the tests failed though. It looks like it's failing on the async tests but that has been there all the time, no? Anyway, this is my first PR so please let me know if i've missed anything that needs to be fixed.

ramasilveyra commented 4 years ago

merging, I will fix ci with https://github.com/ramasilveyra/gitpkg/pull/18 by dropping support for old node versions

ramasilveyra commented 4 years ago

thanks for this, it looks great! Sorry for my delay

ramasilveyra commented 4 years ago

Published in v1.0.0-beta.2.