ramawama / TripPrefVisualizer

A project designed for CORE at the University of Florida to help automate the trip selection process.
2 stars 3 forks source link

Read in and prepare the data for storing on current template files #3

Open shumeraa opened 9 months ago

shumeraa commented 9 months ago

Before you start coding, please remember:

Objective:

Before you start:

Writing the Script:

Resources:

lmdulick commented 8 months ago

currently working on the issue

lmdulick commented 8 months ago

pushed ExcelFilter.py, Trip.py, and TripLeader.py into Lauren's-Branch

ramawama commented 8 months ago

pushed ExcelFilter.py, Trip.py, and TripLeader.py into Lauren's-Branch

Hello work looks great, just a few suggestions: make sure to follow github naming conventions when creating branches. We utilize feature branching so we refrain from naming branches with our names in it and name them based on the feature we are working on.

Also I'm not sure if you were at the meeting, but we've decided to use sql tables rather than classes for tripleaders / trips, but no need to delete them in case they are needed in the future.

If you had wanted to test the read excel functions, you can just pass in the prefs template sheet and if you just print a pandas df it will print with all its rows and columns after your data manipulation.

Let me know if you have any questions.

lmdulick commented 8 months ago

update: changed the new branch to 'Read-in-and-store-the-data' and linked it to this issue tab; additionally I'll go ahead and delete the trip.py and tripLeader.py files from this branch but I'll keep a copy of them in case we need the classes in the future