Bugs in ancestral output order

rambaut / Seq-Gen

Sequence simulator

51 stars 17 forks source link

Bugs in ancestral output order #19

Open lamthuy opened 2 years ago

lamthuy commented 2 years ago

There is a small bug where the order of the branches:

in the ancestral output branch 0,1,2 https://github.com/rambaut/Seq-Gen/blob/e8660d73769297d25a88b40d5b828a6fce7784b5/source/evolve.c#L569
while in the WriteTree the order was 1,2,0 https://github.com/rambaut/Seq-Gen/blob/e8660d73769297d25a88b40d5b828a6fce7784b5/source/treefile.c#L567

This causes issue in parsing the ancestral output.

rambaut commented 2 years ago

Thanks for noticing this. I propose fixing this by changing the ancestral output to follow the order given by the tree (1,2,0) as this is less likely to break other things.