rambler-digital-solutions / rambler-it-ios

open source VIPER application
MIT License
333 stars 57 forks source link

Design no future events state for announcement screen #55

Closed etolstoy closed 8 years ago

etolstoy commented 8 years ago

Linked to #9 .

ykamendrovskiy commented 8 years ago

@etolstoy The screen's got refactored and rebuilt from scratch. No-future-events state included

slice

etolstoy commented 8 years ago

We've just finished implementing this screen with the previous design version - migrating to the new one is very expensive. Is it possible to implement it in future versions?

ykamendrovskiy commented 8 years ago

@etolstoy yes, sure. Let's call it Stage 2

etolstoy commented 8 years ago

Great - but we still need this state for Stage 1.

ykamendrovskiy commented 8 years ago

@etolstoy hope that works nofuture

etolstoy commented 8 years ago

@ykamendrovskiy and where does this button lead?

ykamendrovskiy commented 8 years ago

@etolstoy it opens "Отчеты" tab

etolstoy commented 8 years ago

But it's an antipattern - to open other tabs using anything but tab bar itself. Maybe better remove it?

ykamendrovskiy commented 8 years ago

@etolstoy it might look a bit odd in certain cases, except when the only option is to show literally nothing. And I don't think it's an antipattern at all. Antipatterns mislead, or perform unpredictably and it's not this case. This case is about care, help and love.

If it's not difficult to implement I suggest doing it and performing a test-drive and a corridor testing. If people don't like it, fine, we'll remove it then

etolstoy commented 8 years ago

If you say, that it's all about love - than ok! :)

etolstoy commented 8 years ago

Just don't forget to export it in Zeplin.

ykamendrovskiy commented 8 years ago

done