Closed tomhooijenga closed 2 years ago
In handleMetric of class VastAdUnit the metric events are emitted:
handleMetric
VastAdUnit
this.emit(event, { adUnit: this, type: event });
These events are then consumed in createVideoAdUnit:
createVideoAdUnit
Object.values(linearEvents).forEach((linearEvent) => adUnit.on(linearEvent, (event) => { const { type: evtType, data } = event; const payload = { data, errorCode: adUnit.errorCode, tracker }; trackLinearEvent(evtType, vastChain, payload); }) );
createVideoAdUnit assumes there is a data property on the event, but it is never passed in handleMetric.
data
This causes trackProgress to never track because the data including the progress uri is missing. This might be happening to other events as well.
trackProgress
:tada: This issue has been resolved in version 2.4.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
In
handleMetric
of classVastAdUnit
the metric events are emitted:These events are then consumed in
createVideoAdUnit
:createVideoAdUnit
assumes there is adata
property on the event, but it is never passed inhandleMetric
.This causes
trackProgress
to never track because the data including the progress uri is missing. This might be happening to other events as well.