Consecutive emitting "AdVideoComplete" and "AdStopped" causes error

rambler-digital-solutions / video-ad-sdk

VAST/VPAID SDK that allows video ads to be played on top of any player

MIT License

7 stars 5 forks source link

Closed mixalezhnev closed 2 years ago

mixalezhnev commented 2 years ago

If VPAID emits consecutively "AdVideoComplete" and then "AdStopped" we get error from https://github.com/rambler-digital-solutions/video-ad-sdk/blob/067e3df8f1bbafe9817e76d7a07fba23d25b973b/src/adUnit/helpers/dom/elementObservers/onElementVisibilityChange.js#L43 It happens due to absence of intersectionHandlers after emitting "AdVideoComplete". Is it correct behaviour and we should avoid emitting these two events consecutively?

rambler-ui-bot commented 2 years ago

:tada: This issue has been resolved in version 2.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: