rambler-digital-solutions / video-ad-sdk

VAST/VPAID SDK that allows video ads to be played on top of any player
https://rambler-digital-solutions.github.io/video-ad-sdk/docs/
MIT License
9 stars 6 forks source link

Fix VpaidAdUnits that throw error on "getAdIcons" #61

Closed rand0me closed 1 year ago

rand0me commented 1 year ago

Hi guys, at first - huge thanks for maintaining this library, it makes us money! 🙂

Recently I started having lots of creatives that throw when creativeAd[getAdIcons] is being called, but with this patch they work pretty nicely. It would be great if you merged this PR and made a release, otherwise I have to publish and maintain my own fork (which I'd like to avoid 😆).

Please, let me know if I need to reformat the code/commit message/etc. and thanks again for your time and efforts!

andrepolischuk commented 1 year ago

hi, thanks for your pr 🙏

please add the prefix fix: to the name of the commit, because we follow the conventional commits https://www.conventionalcommits.org. and check eslint errors

rand0me commented 1 year ago

@andrepolischuk done 👍

eslint shows few dozen errors, but none are related to my commit. Sorry, I don't have time to resolve all of them 😅

image
andrepolischuk commented 1 year ago

@rand0me thanks!

rambler-ui-bot commented 1 year ago

:tada: This PR is included in version 2.7.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: