search

rambo / TinyWire

My modifications to TinyWire Arduino libs
284 stars 121 forks source link

Interrupt driven request callback #39

Closed JasperHorn closed 6 years ago

JasperHorn commented 6 years ago

Mainly, this is @rshartog's efforts to make the receive callback interrupt driven. On top of that, I fixed the repeated start condition, which was broken after his changes.

JasperHorn commented 6 years ago

I think that an additional 70 bytes could be saved for anyone using tws_delay() by implementing it simply as a call to delay. (Though there shouldn't be a need to use that function in new code, and the size does of course not change if you don't use the function.)

rambo commented 6 years ago

This got broken by another PR merge. Someone should take a second look at the conflicts.

JasperHorn commented 6 years ago

Fixed.

The conflict was pretty superficial: a comment and some whitespace interfering with a real change.