search

ramda / ramda-fantasy

:ram::sparkles: Fantasy-Land compatible types for easy integration with Ramda.js
MIT License
1.5k stars 95 forks source link

fantasy-land@1.0.x compatibility #131

Open safareli opened 7 years ago

safareli commented 7 years ago

It's breaking change as sanctuary-type-classes dispatches to namespaced methods so if someone was using ramda-fantasy with some other non fl@1.0.x compatible lib it will break.

But it's not too breaking as every method is as it was before they are just copied to used to define namespaced versions in fl-patch (it also flips ap)

safareli commented 7 years ago

I'm using ramda-fantasy in tests and currently this is what i'm doing.

buzzdecafe commented 7 years ago

this looks fine to me, although it does make me wonder again what the purpose of two separate libs (S & RF) is. See #105

davidchambers commented 7 years ago

We might as well go straight to fantasy-land@2.0.0 now. :)

scott-christopher commented 7 years ago

Do we want this PR to land before we wrap up with a final release?

davidchambers commented 7 years ago

Do we want this PR to land before we wrap up with a final release?

Yes, I think so.

safareli commented 7 years ago

ap needs to be redefined of all structures and S-type-classes should be updated, for this pr to be merged. I think i might have some time this weekend for it.