ramda / repl

The Ramda REPL
34 stars 15 forks source link

Remove `?` from hash #39

Open MattMS opened 7 years ago

MattMS commented 7 years ago

Unless there is a reason that the ? is required, then it seems like parsing the code from the hash would be simpler if it didn't require removing the ? each time.

craigdallimore commented 7 years ago

Agreed - at present the "try in repl" part of the ramda docs includes the ? in its links, so we probably need to account it until we fix it on that side.

MattMS commented 7 years ago

There was a merged PR that changed the ? to a ; in preparation for this. I just checked the docs page and it appears to be working.

So you should be able to include the first character and it would still be valid JS. Then we can update the button click handler to exclude that character.