ramdor / Thetis

The main working repo for changes to Thetis for the Apache Labs line of radios
47 stars 13 forks source link

[Feature] Can only change Rx Ant while in the Ham Bands #404

Open Archcantor opened 5 months ago

Archcantor commented 5 months ago

Describe the bug Rx Ant on the UI can only be changed while in the Ham Bands

To Reproduce Steps to reproduce the behaviour:

  1. Go to Ham Bands
  2. Go to RX Ant control in the UI
  3. Can change to Rx Ant 1, 2, or 3
  4. Go to outside the Ham Bands (SWL)
  5. Go to Rx Ant control in the UI
  6. The selector does not change the antenna

Expected behaviour I expected to be able to change the Rx Ant on any freq.

Screenshots RxAnt

Desktop (please complete the following information): Windows 11, Thetis 2.10.3 x64 dev2 FW 2.2.2 Protocol 2

Additional context When outside the ham bands (SWL) the Rx Ant can be changed in Setup => Ant/Filters and clicking on the closest ham band.

ramdor commented 5 months ago

yes the implementation is to only work with ham bands.

        // set RX antenna to new antenna 1-3
        // this must also cancel any ext input check boxes
        public void SetRXAntenna(int Antenna, Band band)
        {
            if ((band >= Band.B160M) && (band <= Band.B6M))
Roturbo commented 5 months ago

Hello Ramdor,

any "special" reason to work only on ham bands or is there any chance to make it available on any other band SWL ?