search

ramdor / Thetis

The main working repo for changes to Thetis for the Apache Labs line of radios
47 stars 13 forks source link

PureSignal SetPK not set correctly on new Thetis installations for G2 [BUG] #408

Closed w-u-2-o closed 3 weeks ago

w-u-2-o commented 5 months ago

See: https://community.apache-labs.com/viewtopic.php?f=48&t=5004

Per Laurence in that thread:

"Thetis has a parameter SetPk which is important. It is on the linearity form. For a G2 it should be set to 0.6121 and for an Anan7000 it should be set to 0.2899.

We had modified Thetis to set this for G2 radios; but Warren advised me on Saturday that was no longer being set. It looks like the Thetis code has changed again."

ramdor commented 3 months ago

Saturn value of 0.6121 is provided to PSdefpeak(n) function, which updates the data in the PSForm, only if the radio protocol or hardware changes from previous. On a new DB this will obviously update, and on a radio/protocol change this will update.

The reason for preventing this happening all the time is because an end user may tweak the value and will not want it overwritten. There may be a case for adding additional UI on the PSForm to have a default value with radio button, and user value with radio button to make it obvious what is happening.

Will leave this open for now as a reminder.

ramdor commented 3 weeks ago

closing this, as a none issue atm. Eventually I will re-write the implementation to provide a better ui/config.