search

ramdor / Thetis

The main working repo for changes to Thetis for the Apache Labs line of radios. Find us here : https://discord.gg/6fHCRKnDc9
https://discord.gg/6fHCRKnDc9
GNU General Public License v2.0
50 stars 14 forks source link

[Feature]Xvrtr settings are lost when importing a previously exported database #423

Open Ian-Cox-Barnabas opened 4 months ago

Ian-Cox-Barnabas commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behaviour:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Ian-Cox-Barnabas commented 4 months ago

Also, I edited the entries to correct them for the RSGB UK 2m band plan, but these are lost when importing them from a “Thetis_databaseexport...xml” file, but retained if the same edits are applied to the “database.xml” file.

ramdor commented 3 months ago

importing a DB will replace the XVTR settings with those from the database being imported. Current settings will be replaced by those from the db being imported. If there are no xvtr settings in the db being imported, current ones will also be lost. This is not really a bug, but probably requires an option somewhere to 'ignore' xvtr on import. Will leave this as a feature request.

Ian-Cox-Barnabas commented 3 months ago

I think the xvrtr settings are not SAVED in the database. After entering the xvrtr settings into Thetis I saved a new database, but when importing that same saved database the xvrtr settings were lost, though everything else seems to be OK. Using a text editor, I manually inserted the xvrtr entries into the database, then they were retained on the next import & export. That would appear to be a bug. :-)

Ian-Cox-Barnabas commented 3 months ago

Thanks Richie, I understand and agree with your comments BUT..

I think the ‘bug’ appears to be that the xvrtr settings are not SAVED with the database. As I’ve just commented on GitHub, I saved a new database after entering the xvrtr settings into Thetis, but they were lost when retrieving that same database. I edited the database using a text editor and manually entered the xvrtr settings – then they were there on importing that database (as your comment would suggest). Once manually edited into the database, they appear to be retained on subsequent Thetis save/import cycles (not overwritten on save?)

Ian G3PRN

From: Richie @.> Sent: Sunday, July 7, 2024 5:39 PM To: ramdor/Thetis @.> Cc: Ian-Cox-Barnabas @.>; Author @.> Subject: Re: [ramdor/Thetis] Xvrtr settings are lost when importing a previously exported database (Issue #423)

importing a DB will replace the XVTR settings with those from the database being imported. Current settings will be replaced by those from the db being imported. If there are no xvtr settings in the db being imported, current ones will also be lost. This is not really a bug, but probably requires an option somewhere to 'ignore' xvtr on import. Will leave this as a feature request.

— Reply to this email directly, view it on GitHub https://github.com/ramdor/Thetis/issues/423#issuecomment-2212503730 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BIPTEPVBCKZUYCTUK3HMXUDZLFVKNAVCNFSM6AAAAABHWIARFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGUYDGNZTGA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/BIPTEPUXAXG22QOIIXSURG3ZLFVKNA5CNFSM6AAAAABHWIARFOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUD4AQLE.gif Message ID: @. @.> >