search

rameau-fr / MC-Calib

A generic and robust calibration toolbox for multi-camera systems
MIT License
377 stars 54 forks source link

Feature/improved-documentation #59

Closed Harvendois closed 6 months ago

Harvendois commented 6 months ago

PR for Improved Documentation by Jungha Cho

Key Changes:

  1. README.md improved for easier installation of the toolbox (commands like NVidia runtime and Xserver displays are omitted).
  2. Windows.md created to guide Windows OS users installing the toolbox.
  3. contributing.rst under docs directory improved to catch errors and allow Windows user clearer guidance.
  4. CMakeLists.txt edited to add ASanitizer disable/enable option when compiling. This allows us to run both ASanitizer leak test and Valgrind tests easily.
  5. create_charuco_board.cpp edited to disable display-related codes (such as cv.imshow()), which were prone to make errors.
Harvendois commented 6 months ago

Thank you for checking the PR in detail. I fixed all the minor comments that you have made and commited accordingly.