rameau-fr / MC-Calib

A generic and robust calibration toolbox for multi-camera systems
MIT License
377 stars 54 forks source link

test not good in my dataset about fish images #66

Open zuixiaosanlang opened 5 months ago

zuixiaosanlang commented 5 months ago

reproject error: image

other message: image

I don't know if it's normal.

my dataset and configs link: https://drive.google.com/file/d/1OOtaLzSQAoGMMsNgfCF0Aaujv5h6Ac0H/view?usp=drive_link

rameau-fr commented 5 months ago

Thank you very much for using MC-Calib. Indeed, such a poor reprojection error should not occur. It seems that only some images are "outliers," causing problems during the calibration, and I would assume it is because their angle is quite tricky and that the intrinsic calibration for strong peripheral aberration is not very good. I would like to suggest a few modifications to your current calibration pipeline:

zuixiaosanlang commented 5 months ago

@rameau-fr thanks.

configuration file calib_param_scene_1.zip

image

rameau-fr commented 5 months ago

Your calibration configuration looks great, but I would probably increase the min_per_pts to about 0.4 just to be sure to avoid critical scenarios. Also, I noticed that you generate your calibration boards from another website; I am quite unsure if these boards are compatible with MC-Calib. You should generate the calibration boards directly from the toolbox as described in the tutorial.

BAILOOL commented 3 months ago

@zuixiaosanlang We've fixed a bug related to fisheye calibration. It's now merged to master branch. Please try the calibration again - it must result in the lower reprojection error.

zuixiaosanlang commented 3 months ago

@BAILOOL thanks, i notice this before. and i think i correct it, because i get the same result. i forget to point this out. my code: image

i also change to your new code.but get the same result.

rameau-fr commented 3 months ago

Hello, Have you regenerated the board using MC-Calib directly? The Calib.io boards are most likely not compatible with the toolbox.