search

ramenmen / pe

0 stars 0 forks source link

Invalid file path not handled in corrupt json. #11

Open ramenmen opened 3 years ago

ramenmen commented 3 years ago

I changed stock_picture.png in one of the patients to stock_pictur and the data still loads but the patient does not have a picture.

Screenshot 2020-11-13 at 5.13.22 PM.png Screenshot 2020-11-13 at 5.13.59 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Reason for changing the severity to "VeryLow": It does not break the usability of the application. Can be easily recovered by adding any profile picture back.

Reason for rejecting: It is the correct behaviour. If CliniCal cannot find the file named "stock_pictur.png" inside your data folder, then the picture will not show up.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In the DG, it states that an invalid value would result in the app starting with an empty set of data. Hence, the blank image is not the correct behaviour stated in the DG and it is still a bug and should not have been rejected.

Screenshot 2020-11-19 at 4.25.05 PM.png

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]