ramensoftware / windhawk-mods

The official collection of Windhawk mods
310 stars 56 forks source link

[Vertical Taskbar for Windows 11] Windows notifications being misplaced #1006

Closed bergamin closed 1 month ago

bergamin commented 1 month ago

Mod author: @m417z

Expected Behaviour:

Notifications should show up near the notification button (bottom)

Actual Behaviour

Notifications are showing up near the Start menu button (top)

Evidence

Mod Behaviour:

image

Native behaviour:

image

Other mods installed in this system

m417z commented 1 month ago

Good catch, I'll fix it in the next version. Meanwhile, if you want to get this right now, you can fork the mod and replace:

    *y = rc.top;

With:

    if (g_target == Target::StartMenu || g_target == Target::SearchHost) {
        *y = rc.top;
    }

Let me know if you need more details about it.

bergamin commented 1 month ago

Not as critical of an issue to make me go into the trouble of forking it and trying to understand how it works, but thanks for the suggestion

m417z commented 1 month ago

Fixed in version 1.2.4.

Venthe commented 1 month ago

@m417z Can confirm that it works

@bergamin Just FYI, you can fork in in app; and edit it there. The line in question is 2422.

It is as easy as details (main window)->fork (mod details of original)->(change line 2422)->compile mod->exit editing mode; plus disabling the original

e: Thanks @m417z ; you haven't given me enough time to even explain the alternative :D Man, I admire your work so much.