New mod per-app-language-preferences 1.0

ramensoftware / windhawk-mods

The official collection of Windhawk mods

312 stars 56 forks source link

New mod per-app-language-preferences 1.0 #1235

Closed yezhiyi9670 closed 1 week ago

m417z commented 1 week ago

Looks great. Small notes:

Some compiler options and includes can be removed, e.g. wininet.
Small memory leak for an empty string on line 86.
Why limit it to 64-bit?
I think the name/description can be made clearer, it's not a mod for controlling the UI language, but for controlling the input language. What do you think?

yezhiyi9670 commented 1 week ago

I have been copying my previous code, so apologies for the careless mistakes.

For the last point, it is intended for changing the UI language, not the input langauge.

m417z commented 1 week ago

That's what I understood from the linked Microsoft post, which says "Let me use a different input method for each app window". Perhaps this link is not quite about the same, then. Also, how about posting this screenshot to the description?

Also, using a static string variable makes the hook non-thread safe.

Also, "Some compiler options and includes can be removed, e.g. wininet" - includes too.

yezhiyi9670 commented 1 week ago

What would be the best practice if I need a string buffer in the hook? Just make it non-static?

m417z commented 1 week ago

Yes, in this case, why not? Also another small notice, the size that's specified includes the null terminator, so it should be 2049, not 2048.