ramensoftware / windhawk-mods

The official collection of Windhawk mods
314 stars 56 forks source link

Wrong Icon for some Applications in Taskbar #226

Open svargh opened 1 year ago

svargh commented 1 year ago

System; Microsoft Windows [Version 10.0.22621.1702] Windhawk v1.3.1 beta Installed mods; Disable grouping on the taskbar Taskbar Clock Customization Taskbar height and icon size Taskbar Labels for Windows 11 Taskbar Thumbnail Reorder Taskbar Volume Control Virtual Desktop Preserve Taskbar Order

For some applications (terminal and cygwin) a wrong icon is shown. It takes an icon from another random open application. For example a console application (Syncthing) has an icon from Greenshot, Or another command prompt using icon from Device Manager.

image

m417z commented 1 year ago

Do you know which mod causes it? I'd assume the disable grouping mod is most likely to be related. Do you have a way to reproduce the problem? Does it happen often, or did it happen only once? Does it happen if you disable all most but Disable grouping on the taskbar?

svargh commented 1 year ago

Yes, it is indeed the disable grouping mod. It should occur if I open multiple windows(cygwin terminal shortcut) of same icon. Then switch to next virtual desktop, then back. It seems that the mod is then using the icon from the underlying exe file of the shortcut(mintty.exe) instead the icon shortcut: windhawk-bug-disable-grouping

However, I was not able to reproduce my problem where an random icon from another running application is used. It occurs when "too many" windows are open (Having many windows open on 2x43"@4K screens) and only the Terminal.exe is affected using icon from another complete different running application. For example. I recently opened the Windhawk application, and now Terminal application has now the Winhawk icon: image

m417z commented 1 year ago

It seems that the mod is then using the icon from the underlying exe file of the shortcut(mintty.exe) instead the icon shortcut

If that's the first window of the group (e.g. the first mintty window), and if the settings "Keep pinned items separated" and "Use window icons" are disabled (that's the default), the icon should be the same as it would be without the mod. Are you sure that there's a difference?

The icon is by default the app icon, not the window icon, which might be what you're seeing. That's the default taskbar behavior. You might want to try the "Use window icons" option of the mod.

For example. I recently opened the Windhawk application, and now Terminal application has now the Winhawk icon

That's clearly a bug, but I never encountered it, even though I'm using the mod on a daily basis. Can you try to come up with reproduction steps that I can use to trigger the bug?

svargh commented 1 year ago

My assumption about the a mod using the application icon is wrong. It just takes any random icon. I am able to reproduce it on my host system where it picks up any icon, but in a VM with the exact same Windows version, it seems to be not so "random" (only application window).

The only difference is that the host system is daily docked and undocked at different places.

One thing I noticed: This bug is related only mintty(Cygwin() and Terminal.exe, Other apps do not have this bug: Firefox, Excel, Kate, Thunderbird, TotalCMD, TortoiseHG, IntelliJ , Clock, Greenshot, Word

m417z commented 1 year ago

What are your mod settings? Is the "Use window icons" option enabled? Other options?

svargh commented 1 year ago

""Use window icons"" is disabled. Other options in the mod are disabled (default).

m417z commented 1 year ago

And if you turn on "Use window icons" (and then restart explorer/the computer), can you still reproduce the bug?

svargh commented 1 year ago

I enabled "Windows Icons":

m417z commented 1 year ago

OK, thanks, I'll keep an eye on the mintty/Terminal issue. Still, if you find more specific reproductions steps, let me know.

Dook1 commented 1 year ago

Same problem with System Informer. Reproducibility: always.

m417z commented 1 year ago

@Dook1 I can't reproduce it, both with and without the "Use window icons" option.

image

Dook1 commented 1 year ago

Now I can't reproduce it either. This is probably my experiments with Taskbar Styler. Sorry.

svargh commented 1 year ago

Now I can't reproduce it either. This is probably my experiments with Taskbar Styler. Sorry.

Can you try with cmd or terminal app also open and showing the title? Thanks

Dook1 commented 1 year ago

I tried now with cmd and with terminal. No problem at all.