search

ramensoftware / windhawk-mods

The official collection of Windhawk mods
302 stars 55 forks source link

The "Classic navigation bar" mod is not compatible with a custom Explorer start folder #487

Open LesFerch opened 9 months ago

LesFerch commented 9 months ago

If you set a custom start folder for Explorer via the registry (as shown below) this will partially break the "Classic navigation bar" mod.

With the custom start folder reg setting, Explorer still opens with the classic navigation bar if you execute a path, such as "C:\" or "Shell:Profile", but if you just run "Explorer" or "Explorer.exe", then Explorer will only occasionally open with the classic navigation bar. Most of the time it will open with the new navigation bar or no navigation bar at all.

I understand if there's no way to avoid this issue, but I thought it best to bring it to your attention.

Also, if you can suggest a different way to set a default start folder for Explorer that would be great.

Thanks!

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Classes\CLSID\{52205fd8-5dfb-447d-801a-d0b52f2e83e1}\shell\OpenNewWindow\command]
@="explorer C:\\"
"DelegateExecute"=""
m417z commented 9 months ago

Which configuration are you using? Classic navigation bar or Classic ribbon UI (no tabs)?

Are you using the option to launch folder windows in a separate process?

What's the easiest way to reproduce the issue? Does Win+R, explorer.exe, Enter reproduces it for you?

This issue might be related to https://github.com/ramensoftware/windhawk-mods/issues/519.

LesFerch commented 9 months ago

This issue is only applicable to "Classic navigation bar".

The "launch folder windows in a separate process" makes no difference. Neither does "open each folder in its own window". I tested all combinations.

Yes, I think this is the same issue as #519.

Yes, Win+R, explorer.exe reproduces the issue. It results in one of no address/search bar, gray address/search bar, or new Explorer loads. You can also reproduce the issue by applying this registry change:

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\SOFTWARE\Classes\CLSID\{52205fd8-5dfb-447d-801a-d0b52f2e83e1}\shell\OpenNewWindow\command]
@="explorer c:\\"
"DelegateExecute"=""
elbadcode commented 9 months ago

I don't get the issue when launching through run or any windows process so maybe there are some other conditions. I have UAC disabled so I'm always launching with privilege escalation but I tried on a standard user and still didn't reproduce that way

LesFerch commented 9 months ago

@elbadcode I'm testing on build 22631.3085. What build are you testing on?

LesFerch commented 9 months ago

@elbadcode It doesn't always exhibit the issue just running explorer.exe.

Try win+r explorer c:\

Try it multiple times.

m417z commented 9 months ago

It doesn't seem to happen for me. Any other ideas?

https://github.com/ramensoftware/windhawk-mods/assets/4129781/ab45f909-7329-4c89-aa7b-c06fd42cad37

m417z commented 9 months ago

I could reproduce it. It seems that regardless of the option to launch folder windows in a separate process, a new process is created in these cases. This process is started by svchost.exe, and I believe that adding it to Windhawk's inclusion list will fix the problem.

Go to Windhawk's settings, advanced settings, more advanced settings, and add svchost.exe to the process inclusion list. Let me know whether it fixes the problem.

image

LesFerch commented 9 months ago

Sorry to report that adding svchost.exe to the inclusion list did not fix the issue for me.

m417z commented 9 months ago

Too bad, that means that the issue is about something else and requires more research.

elbadcode commented 8 months ago

seems the best option for now is to add the launching application to inclusions. The worst culprint for me was modorganizer.exe for skyrim. It caused the bug 10/10 times but adding to inclusion affects the explorer processes it starts which makes sense in that case due to it using a VFS. I'm actually not sure what else to test with since that was the only 100% reliable problem causer for me

m417z commented 6 months ago

I just updated the mod to version 1.0.2, and this issue might now be fixed. Can you please check that?

LesFerch commented 6 months ago

I updated to 1.0.2, but I don't get consistent results. Frequently, Explorer opens with no address/search bar, like this:

image

But sometimes it works fine and it doesn't seem to matter if my Explorer start folder is set to Home, This PC, or a custom folder:

image

m417z commented 6 months ago

Thanks for checking, looks like it's not fixed.

LesFerch commented 6 months ago

Upon further testing, it appears that I mainly (perhaps only) see the issue when Explorer is launched with a starting folder parameter via the Run box, command line, or a shortcut. For example, running explorer c:\ will launch Explorer without an address/search bar.

HtheB commented 6 months ago

Upon further testing, it appears that I mainly (perhaps only) see the issue when Explorer is launched with a starting folder parameter via the Run box, command line, or a shortcut. For example, running explorer c:\ will launch Explorer without an address/search bar.

Happens for me too; however, if you try it a second or third time, it works again. It's just hit or miss. Sometimes it works, and sometimes it doesn't.