ramensoftware / windhawk-mods

The official collection of Windhawk mods
222 stars 43 forks source link

General question regarding Taskbar Height and Icon Size #719

Closed R4mb4Z4mb4 closed 1 month ago

R4mb4Z4mb4 commented 1 month ago

Hey, I don't really have a bug to report but I have a question as to how the taskbar height and icon size mod works in regards to downloading those icons from Microsofrt, once there has been a new update?

Because for me right now, after installing KB5037853 2 days ago, nothing happens, while before it usually happened within 24 hours.

I think KB5037853 is still in a state of an optional update. It's not a beta, but just still in an early, optional installation state.

Has it something to do with that and if so, why can't the mod still download those icons for it?

Thanks in advance and I love your tool, windhawk!

m417z commented 1 month ago

Hi, I checked, and symbols for KB5037853 are available.

Please attach debug logs by following the instructions on the Troubleshooting page: https://github.com/ramensoftware/windhawk/wiki/Troubleshooting#some-or-all-windhawk-mods-dont-work

  • Disable the mod.
  • Go to the mod's Advanced tab.
  • Set Debug logging to Detailed debug logs.
  • Click on Show log output.
  • Enable the mod.
  • Verify that the mod doesn't work, copy the log and save it to a file.
  • Set Debug logging back to None.
m417z commented 1 month ago

Also, moved the issue from windhawk to windhawk-mods.

R4mb4Z4mb4 commented 1 month ago

Alright, thanks for the reply. Just done that. I'm already seeing some sort of an error there, but no clue what that means. Here it is:

log.txt

Maybe something is going on within that part here, but I'm sure you understand that all better. :D

09:06:20.859 19404 explorer.exe [WH] [anonymous-namespace'::LogSymbolServerEvent]: SYMSRV: Can't create C:\ProgramData\Windhawk\Engine\Symbols\Taskbar.View.pdb\CDD4E81ECCA544A180BE1DC8578075AB1\Taskbar.View.pdb 09:06:20.859 19404 explorer.exe [WH] [anonymous-namespace'::LogSymbolServerEvent]: SYMSRV: RESULT: 0x80070005 09:06:20.859 19404 explorer.exe [WH] [LoadedMod::SetTask]: engine\storage_manager.cpp(154)\windhawk.dll!00007FFB07624848: (caller: 00007FFB07616A6E) Exception(17) tid(2ce4) 80070005 Zugriff verweigert 09:06:20.859 19404 explorer.exe [WH] [LoadedMod::LogFunctionError]: Mod taskbar-icon-size error: engine\symbol_enum.cpp(201)\windhawk.dll!00007FFB0762CD74: (caller: 00007FFB0761A66E) Exception(16) tid(2ce4) 806D0005 09:06:20.859 19404 explorer.exe [WH] [`anonymous-namespace'::ModDebugLoggingScope::~ModDebugLoggingScope]: <<< Exiting LoadedMod::FindFirstSymbol3 09:06:20.859 19404 explorer.exe [WH] [taskbar-icon-size] [947:HookSymbols]: Wh_FindFirstSymbol failed 09:06:20.859 19404 explorer.exe [WH] [`anonymous-namespace'::ModDebugLoggingScope::~ModDebugLoggingScope]: <<< Exiting LoadedMod::Initialize

m417z commented 1 month ago

The error seems to be:

Can't create C:\ProgramData\Windhawk\Engine\Symbols\Taskbar.View.pdb\CDD4E81ECCA544A180BE1DC8578075AB1\Taskbar.View.pdb
RESULT: 0x80070005

So for some reason, the folder is not accessible. Does the C:\ProgramData\Windhawk\Engine\Symbols folder exist?

Reinstalling Windhawk might help.

R4mb4Z4mb4 commented 1 month ago

The error seems to be:

Can't create C:\ProgramData\Windhawk\Engine\Symbols\Taskbar.View.pdb\CDD4E81ECCA544A180BE1DC8578075AB1\Taskbar.View.pdb
RESULT: 0x80070005

So for some reason, the folder is not accessible. Does the C:\ProgramData\Windhawk\Engine\Symbols folder exist?

Reinstalling Windhawk might help.

Yes, it exists. Would it be worth a try to just close Windhawk and then remove the symbols folder, or won't Windhawk recreate it anyway?

m417z commented 1 month ago

That won't work - it's created by the installer, and has special permissions. It's actually better to exit Windhawk, then remove the folder, then reinstall it. Let me know if that works.

R4mb4Z4mb4 commented 1 month ago

That won't work - it's created by the installer, and has special permissions. It's actually better to exit Windhawk, then remove the folder, then reinstall it. Let me know if that works.

Will do. Give me a second.

R4mb4Z4mb4 commented 1 month ago

b4ZVLae

Just installed it again, and it started downloading the icons right away! :)

I mean, I could have got to the idea of reinstalling Windhawk by myself tbh....the reason I asked here instead and didn't just reinstall it, is because I remember in the past this was once actually happening because the icons took a while to show up on the microsofrt servers.

So I thought a reinstall actually won't do anything.

But thanks a ton for your help and again; I appreciate your contribution by Windhawk and this project!

Have a great day! :)

m417z commented 1 month ago

Great, I'm glad that it worked. Indeed the missing symbols is the more common problem, I haven't seen the folder permissions problem before. Perhaps you removed it manually in the past?

In any case, I'll keep an eye on this issue, and will consider implementing a workaround into Windhawk itself in the future.

R4mb4Z4mb4 commented 1 month ago

Great, I'm glad that it worked. Indeed the missing symbols is the more common problem, I haven't seen the folder permissions problem before. Perhaps you removed it manually in the past?

In any case, I'll keep an eye on this issue, and will consider implementing a workaround into Windhawk itself in the future.

Alright, sounds good!

But one more thing to what you said: No, there is actually barely a chance that I did something with the folder permission, because it's been not that long ago when I did a clean install of w11 again. And afer that I installed Windhawk right away. Since then, I think I installed two Windows updates where each time the download of those icons worked just normal. It was just now when all of a sudden it stopped working.

I mean, who knows. Generally I know what Im doing on my pc, but is there a chance that I did something which interfered with the folder permission? Yes. Is it likely? No. I didn't even mess with the registry this time, nor did I touch the permissions/ownership of certain folders.

Anyways, thanks again for the help.

Edit: Actually, if Im not totally mistaken, I just remember it already didn't download it a few weeks back, when this infamous windows updated appeared which added ads to the start menu and what not. However, the icon download only didn't work when I, just like 2 days ago, installed the update in th state of it being an "optional update". I uninstalled this update after one day, but not only due to Windhawk. But then, 2 weeks later when the update became non-optional, and I installed it again, then Windhawk donwloaded the icons just normal.

m417z commented 1 month ago

Thanks for following up with the additional information, it might help in case I encounter this issue again in the future.