search

ramensoftware / windhawk-mods

The official collection of Windhawk mods
219 stars 43 forks source link

timer-resolution-control: Force limits immediately on mod load and setting change, restore original resolution on mod unload #750

Closed levitation closed 1 week ago

levitation commented 1 week ago

timer-resolution-control: During mod start, force timer resolution limit if the resolution was already changed by the program. During settings change, enforce the new settings immediately by enforcing new limits or restoring the resolution desired earlier by the program. On mod unload restore the resolution desired by the program.

levitation commented 1 week ago

I am not sure what the validation check means here. Since I am modifying an existing mod created by you, it does not seem to be fair for me be the only author?

The readme file says that the @github link needs to point to the initial author's profile. So I kept your profile there. At the same time, the readme does not specify restrictions on the @author field. Do I understand it correctly?

Do you prefer that I keep your profile link at the @github metadata link, and change the @author to my username only? I can do that, but then I am wondering how to handle a situation where later a third author emerges. Then the middle author would vanish from the metadata.

m417z commented 1 week ago

As stated in the readme, only the original author can update their mods.

The mod's github metadata value must match the pull request author's GitHub profile. This means that you can only submit an update for a mod that you originally submitted. If you'd like to update a mod that you didn't submit, you can either submit the changes to the mod author, or submit a new mod instead.

In this case, I'm the mod author, and I develop my mods at https://github.com/m417z/my-windhawk-mods. You can submit a PR there.

Generally, Windhawk mods can have only one author, similarly to a GitHub repository which can have only a single owner. Additional contributors, credits for borrowed code, etc. can be specified in the readme.