search

ramensoftware / windhawk-mods

The official collection of Windhawk mods
268 stars 51 forks source link

Mod Realtime Refresh: Is this possible with only mod update, or need improve Windhawk? #880

Open MuscularPuky opened 3 weeks ago

MuscularPuky commented 3 weeks ago

especially styler series: current stylers only work based on Taskbar/Start/Noti Center state at moment of it's enabled and don't reflect after the state's changed. (e.g. sometimes taskbar resizing stops working)

in that case I type space in any field and redo then resave thier config. it reload the mods and makes the mod works well again

if this behavier's supported in default, would that use much resource? there's no method to detect mod's neglect? remiss?—sry for my english—so frequent refresh the mods every few sec would be best maybe

m417z commented 3 weeks ago

Can you provide a specific example? The styler mods apply styles to elements, and there are several limitations. The right way to improve it is to improve the mods, not Windhawk which is just a platform for the mods to be loaded and configured.

MuscularPuky commented 3 weeks ago

Can you provide a specific example? The styler mods apply styles to elements, and there are several limitations. The right way to improve it is to improve the mods, not Windhawk which is just a platform for the mods to be loaded and configured.

https://github.com/user-attachments/assets/413a3bd9-0e5d-4299-aeb0-01a8b6aeade9

image

I met this twice while I'm recording

m417z commented 3 weeks ago

Are you trying to achieve something similar to https://windhawk.net/mods/taskbar-notification-icon-spacing with the taskbar styler mod? I don't understand where should I look in the video, please describe the problem and mark it in the screenshot.

MuscularPuky commented 3 weeks ago

Are you trying to achieve something similar to https://windhawk.net/mods/taskbar-notification-icon-spacing with the taskbar styler mod? I don't understand where should I look in the video, please describe the problem and mark it in the screenshot.

currently I can't reproduce but I'll reply screenshot when I meet it

  1. Taskbar Styler doesn't keep the decreased system tray size sometimes. so to prevent it—makes only few px diff, I had to enable "Taskbar Notification Icon Spacing" too you mentioned. without it the taskbar becomes bigger and ugly so launched app list is pressed down
  2. flyout losses its acrylic/font and back to default style sometimes
  3. keyboard shortcut keyguide losses their positions and orders sometimes. maybe it doesn't recieve new element position info anymore
  4. Start Menu keyframe animation reverts to default sometimes. e.g. tooltip fade, Show More Suggestions, etc.
  5. Start Menu Show All App stops working sometimes
  6. Quick Settings aka Action Center loss its all styles. this happens more often than others
  7. fortunetely I couldn't meet this problem in Notification Center. thaksfully it still works well
m417z commented 3 weeks ago

This kind of style loss shouldn't happen, but it's difficult to diagnose without a way to reproduce it. Please try to come up with a clear way to reproduce the problem. Include the exact styles that are necessary to reproduce the problem, the exact reproduction steps, and how to identify the style that gets lost.

Also, asking just to be sure: Are you using other customization apps such as TranslucentTB? Or are you running UWPSpy? These tools, like the mod, use XAML diagnostics to monitor for taskbar changes, and there can only be one active monitoring process at a time.

MuscularPuky commented 3 weeks ago

This kind of style loss shouldn't happen, but it's difficult to diagnose without a way to reproduce it. Please try to come up with a clear way to reproduce the problem. Include the exact styles that are necessary to reproduce the problem, the exact reproduction steps, and how to identify the style that gets lost.

Also, asking just to be sure: Are you using other customization apps such as TranslucentTB? Or are you running UWPSpy? These tools, like the mod, use XAML diagnostics to monitor for taskbar changes, and there can only be one active monitoring process at a time.

image normal

image when the problem started

image neglected the problem and get worse

I'm not running TranslucentTB and UWPSpy, at least currently. the longer the run time it happens often and becomes worse I think it's related to Tablet Optimized Tasbkar in the log, there's too many OnVisualTreeChange every time I mouse-over the taskbar but when the problem started—ofc cause unknown, there's no often logs anymore but [2464:operator()]: Re-applying style for Taskbar.TaskListButtonPanel there's no any errors about OnVisualTreeChange and else

m417z commented 3 weeks ago

You didn't provide your styles. I'm sorry, but I need detailed information to be able to look at it.

I also don't have a tablet, so please check that the problem exists with a regular, non-tablet taskbar.

I'm asking you for steps that I can take to see the problem. Steps can be as following, for example:

Without such steps, I have nothing to work with, and I can't check and diagnose the problem.

MuscularPuky commented 3 weeks ago

You didn't provide your styles. I'm sorry, but I need detailed information to be able to look at it.

I also don't have a tablet, so please check that the problem exists with a regular, non-tablet taskbar.

I'm asking you for steps that I can take to see the problem. Steps can be as following, for example:

  • Install Windhawk and the Windows 11 Taskbar Styler mod.
  • Enables styles A, B, C for target X.
  • See that target X has now color A, or width B, or whatever.
  • Click somewhere, change some settings, or do some actions.
  • Observe that X no longer has that color/width/whatever.

Without such steps, I have nothing to work with, and I can't check and diagnose the problem.

Sorry it's almost random. but I suspect the wake up from sleep or unlock I'll test it more in desktop mode and if you don't have a tabelt, you can force-enable it with one of the following registry tricks:

I never tried 2~4 but Google's saying it'll work