ramensoftware / windhawk

The customization marketplace for Windows programs: https://windhawk.net/
https://windhawk.net
GNU General Public License v3.0
1.07k stars 28 forks source link

The search does not work #105

Open Anixx opened 9 months ago

Anixx commented 9 months ago

Pressing Ctrl+F or chosing "Find" from menu does not make any effect.

This happens in browse code mode (not in editing mode)

m417z commented 9 months ago

That's a limitation of VSCode: https://github.com/microsoft/vscode/issues/173643 I could create a custom find widget, but it will require some work. Where do you think it would be useful?

or chosing "Find" from menu

Which menu? The menu should be disabled outside of editing mode.

Anixx commented 9 months ago

The pull-down menu, I meant. It is always there and there is "Find" option but it does nothing. Possibly, should be disabled so not to confuse users.

m417z commented 9 months ago

Can you post a screenshot?

Anixx commented 9 months ago

изображение

m417z commented 9 months ago

I see the red dot on the About button... What's your Windhawk version? It should be hidden, and perhaps it wasn't in an older version.

Anixx commented 9 months ago

1.3 beta I will update and report back.

Anixx commented 9 months ago

So, I installed 1.3.1-beta (although the About dialog says itt is 1.74.2): изображение

The behavior is the same. The "Find" menu item does not disappear.

m417z commented 9 months ago

Post the content of the following files from your computer:

Anixx commented 9 months ago

C:\ProgramData\Windhawk\UIData\user-data\User\settings.json:

{
    "telemetry.telemetryLevel": "off",
    "update.mode": "none",
    "update.showReleaseNotes": false,
    "files.autoSave": "afterDelay",
    "window.title": "${dirty}${activeEditorShort}${separator}${appName}",
    "workbench.editor.restoreViewState": false,
    "workbench.tips.enabled": false,
    "workbench.startupEditor": "none",
    "workbench.layoutControl.enabled": false,
    "security.workspace.trust.enabled": false,
    "editor.inlayHints.enabled": "off",
    "editor.tabSize": 4,
    "editor.insertSpaces": true,
    "editor.detectIndentation": false,
    "clangd.path": "${env:WINDHAWK_COMPILER_PATH}\\bin\\clangd.exe",
    "clangd.checkUpdates": false,
    "window.menuBarVisibility": "classic",
    "workbench.activityBar.visible": false,
    "workbench.editor.showTabs": true,
    "workbench.statusBar.visible": true,
    "git.showProgress": false,
    "git.decorations.enabled": false,
    "windhawk.editedModId": "classic-theme-explorer",
    "windhawk.editedModWasModified": false,
    "workbench.colorCustomizations": {
        "window.activeBorder": "#00ff00",
        "window.inactiveBorder": "#ff0000"
    },
    "git.ignoreMissingGitWarning": true,
    "git.ignoreLegacyWarning": true,
    "git.ignoreWindowsGit27Warning": true
}

Second file does not exist.

m417z commented 9 months ago
"window.menuBarVisibility": "classic",

That should be:

 "window.menuBarVisibility": "compact",

Either you edited it manually, or perhaps one of the very early versions had this value (I don't think so).

In any case, you can just modify the file and change it from "classic" to "compact" to get the desired behavior.

m417z commented 9 months ago

That's a limitation of VSCode: microsoft/vscode#173643

Actually, I was wrong about that. The search can't be added in the sidebar, but it can be added in the main view, which is what's important. I'll add it in the next version, can indeed be handy sometimes.

m417z commented 8 months ago

I tried to add the search functionality in version 1.4, but it seems that it doesn't work properly in VSCode v1.74. I'll try adding it again after I update the VSCode version in one of the future Windhawk updates.