ramensoftware / windhawk

The customization marketplace for Windows programs: https://windhawk.net/
https://windhawk.net
GNU General Public License v3.0
1.06k stars 28 forks source link

Compile does not work after update #125

Closed Anixx closed 7 months ago

Anixx commented 8 months ago

I have installed version 1.4 via update with online installer and now I have this error:

c:\ProgramData\Windhawk\EditorWorkspace\mod.wh.cpp:235:32: error: no matching constructor for initialization of 'WindhawkUtils::SYMBOL_HOOK[2]' WindhawkUtils::SYMBOL_HOOK hooks[2]; ^ c:/Program Files/Windhawk/Compiler/include/windhawk_utils.h:14:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 0 were provided struct SYMBOL_HOOK { ^ c:/Program Files/Windhawk/Compiler/include/windhawk_utils.h:14:8: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 0 were provided c:/Program Files/Windhawk/Compiler/include/windhawk_utils.h:34:5: note: candidate constructor template not viable: requires at least 2 arguments, but 0 were provided SYMBOL_HOOK(std::vector symbols, ^ 1 error generated.

m417z commented 8 months ago

Which mod? Is it from the Windhawk repository? If not, post its code.

Anixx commented 8 months ago

I provided wrong information, I actually used the online installer (10 MB)

Anixx commented 8 months ago

Mod code:

mod.wh.cpp.txt

m417z commented 8 months ago

OK, I see the problem, I'll think about a solution when I'm near a computer.

but actually no mod compiles

What do you mean? What is the error message for other mods?

Anixx commented 8 months ago

Just tried to re-install with full installer, the problem is not fixed.

m417z commented 8 months ago

Yes, that doesn't matter, the installation result is the same in both cases. Regarding my previous question - are there other errors you see?

Anixx commented 8 months ago

No, it seems, the error affects only one mod, which was the first I tried. There is an issue with another mod that previously worked (it made VSChromium to hang and not start again), but it went away after reboot.

aubymori commented 8 months ago

Hi, mod creator here. Issue creator is using an outdated version. The updated version (1.4.6) is on the official repository, and will compile (only) on Windhawk v1.4.

Anixx commented 8 months ago

The author of this mod has fixed this issue. The fixed version is now in official repo.

m417z commented 7 months ago

In this case there's no problem, so I'm closing the issue.

The regression is that you could create an empty hook object, like this:

WindhawkUtils::SYMBOL_HOOK hook;

But now you can't. I'm not sure allowing it is a good idea, I'll wait and see whether there are further complains about it.