search

ramensoftware / windhawk

The customization marketplace for Windows programs: https://windhawk.net/
https://windhawk.net
GNU General Public License v3.0
1.06k stars 28 forks source link

Inform user all apps will be closed when updating Windhawk #141

Closed kwyntes closed 5 months ago

kwyntes commented 5 months ago

When you click Install all open applications will immediately be closed, which is a dangerous operation as it could mean losing unsaved work. I think the user (read: I myself) should be reminded of/warned about this by showing a warning messagebox after clicking install, or at least a red text label informing me the user of this so I they can make sure they won't accidentally lose anything.

m417z commented 5 months ago

Thanks for the report. This looks similar to this issue: https://github.com/ramensoftware/windhawk/issues/72 No programs should terminate or crash. Let's track the issue there. Closing as a duplicate.

m417z commented 5 months ago

I see that you updated successfully. Still, I'd rather fix the crashes if possible. Can you please check Event Viewer for errors or crashes? Open "Event Viewer" from the start menu, go to Windows Logs, then Applications, and look for error events from the time you experienced the problem.

Also, are you using an antivirus software?

kwyntes commented 5 months ago

Event Viewer indeed shows there have been a handful of errors from when I ran the installer:

Event 1062, .NET Runtime

Application: explorer.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: exception code c0000005, exception address 00007FF67A130832 Stack:

... and immediately after that:

Event 1000, Application Error

Faulting application name: explorer.exe, version: 10.0.19041.3758, time stamp: 0xbf79d152 Faulting module name: explorer.exe, version: 10.0.19041.3758, time stamp: 0xbf79d152 Exception code: 0xc0000005 Fault offset: 0x0000000000080832 Faulting process ID: 0x1d30 Faulting application start time: 0x01da4412f1bfda0f Faulting application path: C:\Windows\explorer.exe Faulting module path: C:\Windows\explorer.exe Report ID: 46fc8cfd-844b-438e-8488-6473210c0d50 Faulting package full name:

There interesting ones are probably these however: (all at the same time, in order) Event 1000, Application Error

Faulting application name: windhawk_setup(5).exe, version: 1.4.1.0, time stamp: 0x64a0dc67 Faulting module name: unknown, version: 0.0.0.0, time stamp: 0x00000000 Exception code: 0xc0000096 Fault offset: 0x036a15b9 Faulting process ID: 0x3fb4 Faulting application start time: 0x01da440f813d4211 Faulting application path: C:\Users\qjnri\Downloads\windhawk_setup(5).exe Faulting module path: unknown Report ID: 4a0ae947-f730-490f-a236-545f253dcf13 Faulting package full name:

(... a few application-specific errors for Listary, Thunderbird and DisplayFusion, and some others ...)

Event 1005, Application Error

Windows cannot access the file for one of the following reasons: there is a problem with the network connection, the disk that the file is stored on, or the storage drivers installed on this computer; or the disk is missing. Windows closed the program Windhawk because of this error.

Program: Windhawk File:

The error value is listed in the Additional Data section. User Action

  1. Open the file again. This situation might be a temporary problem that corrects itself when the program runs again.
  2. If the file still cannot be accessed and
    • It is on the network, your network administrator should verify that there is not a problem with the network and that the server can be contacted.
    • It is on a removable disk, for example, a floppy disk or CD-ROM, verify that the disk is fully inserted into the computer.
  3. Check and repair the file system by running CHKDSK. To run CHKDSK, click Start, click Run, type CMD, and then click OK. At the command prompt, type CHKDSK /F, and then press ENTER.
  4. If the problem persists, restore the file from a backup copy.
  5. Determine whether other files on the same disk can be opened. If not, the disk might be damaged. If it is a hard disk, contact your administrator or computer hardware vendor for further assistance.

Additional Data Error value: 00000000

I hope this is useful.

I do not have any antivirus software installed (apart from Windows defender).

m417z commented 5 months ago

Event 1000, Application Error

Faulting application name: explorer.exe, version: 10.0.19041.3758, time stamp: 0xbf79d152 Faulting module name: explorer.exe, version: 10.0.19041.3758, time stamp: 0xbf79d152 Exception code: 0xc0000005 Fault offset: 0x0000000000080832 [...]

This is a crash that was caused by https://github.com/ramensoftware/windhawk-mods/issues/469, so unrelated to the problem of all programs crashing.

Event 1000, Application Error

Faulting application name: windhawk_setup(5).exe, version: 1.4.1.0, time stamp: 0x64a0dc67 Faulting module name: unknown, version: 0.0.0.0, time stamp: 0x00000000 Exception code: 0xc0000096 Fault offset: 0x036a15b9 [...]

That would be interesting to investigate, but unfortunately, this report doesn't contain enough information to work with. The module is unknown. The exception code is 0xc0000096, which means STATUS_PRIVILEGED_INSTRUCTION, but no info regarding which instruction is that and where it's located.

If you have a way to reproduce the crash, collecting a crash dump will likely help. Otherwise, unfortunately I'm afraid there's not much I can do with this information alone.