search

ramensoftware / windhawk

The customization marketplace for Windows programs: https://windhawk.net/
https://windhawk.net
GNU General Public License v3.0
2.13k stars 69 forks source link

Allow install of mods on offline machines #259

Open Mikaz-fr opened 2 months ago

Mikaz-fr commented 2 months ago

With https://github.com/ramensoftware/windhawk/issues/234 an offline installer was provided, allowing offline machines to use Windhawk. But I can't find any information or ways to install mods offline. The mods repository do not allow to download the mods and the program do not allow to load from disk it seems.

Is there any way to install mods to an offline machine other than creating new ones locally on the machine ? Copy pasting sources and re-create the mods locally is working fine but is not so intuitive.

m417z commented 2 months ago

Is there any way to install mods to an offline machine other than creating new ones locally on the machine ?

No, currently that's the easiest way. I'm not sure how often such offline mod installation is needed for users, but it's a valid suggestion, I'll consider it for one of the future versions.

Mikaz-fr commented 2 months ago

Thanks for the answer, I agree I'm not sure it's a very common use case. I guess people can thumb-up this issue if they need it instead of opening a new one.

As said the workaround of creating new mods locally is working fine, so it's not blocking either. Maybe a cheap solution would be to add a button on the Mods website to copy the whole content of the mod. This would make it simpler than the current version of the website.

m417z commented 2 months ago

For now, it's probably easier to go to the changelog, click on the desired version date to open the code on GitHub, and copy/download it from there. It has more convenient copy controls, and it's also allows to install any version.

chocmake commented 2 weeks ago

Was curious if this was feasible for an entirely offline system of mine and tested with the Vertical Taskbar mod, by copying the source code to a file then manually transferring to the system and pasting in the template file for 'Create new mod'.

However it errored when compiling, with Failed to parse settings: not a valid YAML array. Is copy-pasting mod source all that's necessary? As it reads from the OP like this is possible.

(I also tested in an online system using the same method in case there was some dependency that would download but the same error occurred.)

Mikaz-fr commented 2 weeks ago

However it errored when compiling, with Failed to parse settings: not a valid YAML array.

You most likely didn’t copy the full code properly. As indicated above it’s easier to copy from the GitHub code. If you copy from the Windhawk mod page you must disable the button Collapse Readme and Settings on the page so the full settings are copied.

chocmake commented 2 weeks ago

Thanks, that was it.

(Though after compiling it seems the mod has no affect on the latest W11 24H2, at least virtualized and using the portable Windhawk but that would be a separate issue)