Open e391hed12 opened 2 months ago
try this?
{
"theme": "DockLike",
"controlStyles[0].target": "Microsoft.UI.Xaml.Controls.ItemsRepeater#TaskbarFrameRepeater",
"controlStyles[0].styles[0]": "HorizontalAlignment=1",
"controlStyles[0].styles[1]": "Margin=0"
}
looks correct to me but I didn't measure it haha cheers :)
Thanks a lot!!
After some investigations with UWPSpy, I found this element set to a fixed width:
Taskbar.Gripper#GripperControl
Setting its width to Auto
completely eliminated the empty space.
very interesting, it does work, and also, setting its width to a static value seems to set a minimum width for the dock, while still letting it expand: Thanks for sharing!!
@bbmaster123 @AmberWat how about setting width to Auto
in the theme? Any downsides?
I'm not sure what the gripper does, if anything. It looks like it's meant to be some sort of handle for dragging but it seems to be left unused.
If we wanted to be super safe we could probably do Width=Auto
and combine it with something like MinWidth=24
so that it's still there if something needs it.
I suspect it might be the tablet mode thing. Should be possible to verify with the tablet posture registry option.
@m417z
Yes it looks like the gripper is specifically the grey horizontal line in the tablet mode taskbar:
shouldn't be a problem as long as we include MinWidth. Without it, the horizontal grey line is missing. Other than that, it makes it a bit hard to right click the taskbar. We could also add a 5px margin to the framerepeater to mitigate this:
{
"theme": "DockLike",
"controlStyles[0].target": "Taskbar.Gripper#GripperControl",
"controlStyles[0].styles[0]": "Width=Auto",
"controlStyles[0].styles[1]": "MinWidth=24",
"controlStyles[1].target": "Microsoft.UI.Xaml.Controls.ItemsRepeater#TaskbarFrameRepeater",
"controlStyles[1].styles[0]": "Margin=5,0,5,0"
}
Otherwise, we could change the BackgroundFill in the theme from Collapsed to Opacity=0
Otherwise, we could change the BackgroundFill in the theme from Collapsed to Opacity=0
I think that's fine, the taskbar is not clickthrough anyway (https://github.com/ramensoftware/windhawk-mods/issues/805), at least the empty space could be used for the menu and perhaps click actions with the mod.
Fair enough. Thoughts on 5px on each side vs 0px or some other value? I can push it through tonight
@m417z
Otherwise, we could change the BackgroundFill in the theme from Collapsed to Opacity=0
That doesn't work, at least when I test it. RootGrid
is the element that controls where right clicking summons the menu.
Other than that, it makes it a bit hard to right click the taskbar. We could also add a 5px margin to the framerepeater to mitigate this
Well, I actually did put a slight padding on RootGrid
. It doesn't make sense to have properties on multiple elements working towards the same thing.
Maybe get rid of the margin on TaskbarFrameRepeater
and instead up the padding on Taskbar.TaskbarFrame#TaskbarFrame > Grid#RootGrid
to Padding=6,0,6,0
? (I think a total padding of 6 looks best)
@AmberWat done! feel free to ping me if any more changes are needed :)
Is there any way to separate widget to left from dock in DockLike
Is there a way to eliminate that space to the right of the Opera icon?