Wrong rendering of themes

Jan-Bober commented 1 month ago

Some themes don't render properly: Translucent: Squircle: RosePine: DockLike:

My applied styles: Taskbar.ExperienceToggleButton#LaunchListButton[AutomationProperties.AutomationId=StartButton] Visibility=Collapsed

systemtray:OmniButton#NotificationCenterButton > Grid > ContentPresenter > ItemsPresenter > StackPanel > ContentPresenter > systemtray:IconView#SystemTrayIcon > Grid > Grid > systemtray:TextIconContent Visibility=Collapsed

SystemTray.Stack#NonActivatableStack Visibility=Collapsed

Version: 1.3.7 Windows 11 Home 23H2

bbmaster123 commented 1 month ago

hmm yes so squircle needs a fallback color, I must have missed that so I'll go ahead and add that in asap the others seem to be rendering correctly if transparency effects is turned off in Settings under Personalization > Colors. If transparency is turned on, and the other themes look like this let me know.

Jan-Bober commented 1 month ago

So the problems are: Translucent isn't fully translucent Squircle: there are no tark blocks behind icons and it doesn't show which app is running nor which is open Rosepine: Right panel looks diffrent Docklike: bg of dock is black

I turned off transparency effects and it didn't change anything Also in rosepine the active app has weirdly placed the red square(screenshot below because it wasn't visible previously)

Jan-Bober commented 1 month ago

I disabled transparency in settings and I noticed that effect on themed notification center changed. Before: After: How to impact this shade so it is completly transluicent or with acrylic blur( if it is not possible without transparency effect i have a mod idea of transparency effect in most apps(like settings, file explorer etc.)

bbmaster123 commented 1 month ago

some thoughts:

your screenshots look correct, this is the expected behavior
No, when transparency effects are turned off, Acrylic doesn't work, which is why we need a fallback color, otherwise its just invisible. This is why Squircle has no background color when transparency is off, and why I need to go add one in
Yes, Squircle used to have a blue outline, but the author decided to remove it. There is some indication of what state its in (running, pointerover, etc) when transparency is on, but apparently not when off. I'll fix this so it follows what it does when transparency is on.
The weather panel looks different because of Microsoft, hence why I had to make a weather on left/right variant
Black is Docklike's fallback color when transparency is off. what color do you think it should be?
RosePine is intended for a smaller taskbar, see the notes at the top over here: https://github.com/ramensoftware/windows-11-taskbar-styling-guide/tree/main/Themes/RosePine However if you want to, you can adjust it so it works with the taskbar size you're using

see the guide for changing background colors: https://github.com/ramensoftware/windows-11-taskbar-styling-guide to set completely transparent, you can use Background=Transparent happy to expand on that if you have any questions

mod idea? I'm listening... cheers :)

Edit: okay I've updated Squircle (both variants) Give the updated code a try and let me know if you still see any issues with the theme https://github.com/ramensoftware/windows-11-taskbar-styling-guide/blob/main/Themes/Squircle/README.md

ramensoftware / windows-11-taskbar-styling-guide

Wrong rendering of themes #64