Faults details not handled properly

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Provide custom exceptions in the WSDL and map them properly into soap faults
2. generate code using wsdl2objc
3. send a request that should result in a fault
4. the custom exception is returned into the fault's details

What is the expected output?
SOAPFault.detail should contain the custom exception.

What do you see instead?
SOAPFault.detail is nil

This is because it is assumed that the detail contains only a string
and [NSString deserializeNode:] is used.

Original issue reported on code.google.com by pmilosev on 1 Jun 2010 at 3:47

[GoogleCodeExporter]

You can find a fix for this issue here:
http://github.com/pmilosev/wsdl2objc/commit/d646545809c0a3cb8e94149339076bfef3d6
6b61

Please note that I have tested only the SOAP1.1 part.
I think the same code applies to SOAP1.2 but you might want to double check it
as I am not to much familiar with it.

Original comment by pmilosev on 1 Jun 2010 at 3:51

[GoogleCodeExporter]

My incompetence shows... How does one merge your github changes into this 
codebase?

Original comment by hasse...@gmail.com on 2 Jun 2010 at 11:52

[GoogleCodeExporter]

I would suggest you check out the project with git,
then make patch for any commit you find suitable for your repository (there 
shouldn't be many up until now).
Otherwise you can tell which commits do you want and I can make the patches for 
you (but might take me some time since currently I am overbooked).

Other possibility would be to checkout the code with git and add your svn 
repository as a remote (note I use different branch called 'nca') ... then you 
can merge our branch with yours.

regards

Original comment by pmilosev on 14 Jun 2010 at 5:32

[GoogleCodeExporter]

I really don't see why you bothered going the git route when you could simply 
have branched in svn. It's not like you couldn't get write access.

Original comment by hasse...@gmail.com on 15 Jun 2010 at 8:00

[GoogleCodeExporter]

Couse I like it ;)

Really I don't like going into argue now which SCM is better, and I really 
don't see your problem.
I offered you several ways how you can get my code.
After all you can still grant me a write permission to your repository and I 
will merge my branch by myself.
I just offered you the opportunity for you to control what will go into your 
repo and what will not.

Original comment by pmilosev on 15 Jun 2010 at 2:05

[GoogleCodeExporter]

I just added you to the list of committers. Thanks for your work, I just don't 
have time to merge your stuff in. Can you do that? It would be appreciated.

Original comment by hasse...@gmail.com on 22 Jun 2010 at 10:31

[GoogleCodeExporter]

sure no problem,

I'll do it once I finish my project (I hope by the end of the next week).
Should I do it directly in trunk, or in a branch that you can then easily merge 
?
Note that my changes are only tested on iPhone, and for some stuff (e.g. self 
signed certificates) there might be a better solution on MAC.

thanks for the write privileges 

regards

Original comment by pmilosev on 22 Jun 2010 at 10:36

[GoogleCodeExporter]

Original comment by pmilosev on 2 Mar 2011 at 3:14

• Changed state: Started

[GoogleCodeExporter]

Merged into:
/branches/nca

Hopefully would go into /trunk soon

Original comment by pmilosev on 5 Mar 2011 at 12:44

• Changed state: Fixed