search

rameshsyn / react-location-picker

A react component to pick a location using google maps
https://react-location-picker.netlify.app/
MIT License
47 stars 21 forks source link

Replace the unmaintained/outdated react-google-maps dependency #23

Open rideyourstyle opened 4 years ago

rideyourstyle commented 4 years ago

Are there any intentions to replace the unmaintained (react-google-maps) dependency with a maintainend one?

The package @react-google-maps/api is a maintained one, based on react-google-maps.

When I use the react-location-picker with react 16.13.1 we have some deprecation warnings. That's also the reason why we moved from react-google-maps (last commit 2 years ago) to @react-google-maps/api

rameshsyn commented 4 years ago

@rideyourstyle Thanks for raising the issue. Didn't know about the @react-google-maps/api. Yes, I want to replace it. Would you mind sending a PR replacing the react-google-maps package? seems like you already have experience with it. react-location-picker only uses a few components from react-google-maps, so it shouldn't take time replacing it.

rideyourstyle commented 4 years ago

I will give it a try. I have no expirience with "modules" but it seems possible to replace it ;-)

rameshsyn commented 4 years ago

@rideyourstyle 👍

rideyourstyle commented 4 years ago

Done #24 :-) The replacemant itself was easy, but it was the first time I work on a compiled lib. I added also mapOptions to modify the map.

Because componentWillReceiveProps causes deprecation warnings, I will replace it in my fork.

rideyourstyle commented 5 months ago

I think I can close this PR, because there will be way more issuses with this librarie(s) in the meantime...