ramess101 / JCED_FOMMS_Manuscript

0 stars 1 forks source link

Reviewer 2 Comment 1 #26

Open ramess101 opened 5 years ago

ramess101 commented 5 years ago

@mrshirts @jpotoff @msoroush

section 3.4: this case study ignores a paper where a Mie force field (also lamda=16) was earlier proposed for cyclohexane, with (I guess) essentially the same results. Differences should appear only because the objective function is slightly different here. The conclusion of this work is that the here proposed force field is „the most accurate“. Omitting the previous study is (at least) awkward, because the authors seem to be aware of the line of developments from these authors, as the reference list shows. Is there a reason for omitting the study mentioned above from the list of „most reliable force fields from literature. Ref 22,24,27,55,56,57“ ?

The reviewer never clarifies what paper has a Mie force field for cyclohexane. @jpotoff @msoroush Any ideas which paper the reviewer is referring to? Who are "these authors" that are included in our reference list? I can't find one for TAMie (the only other Mie family we cite). I know there are parameters obtained with SAFT-gamma that use fractional lambda values and some single-cite cyclohexane Mie models. But I don't think we have any data for those models.

ramess101 commented 5 years ago

@msoroush

Yeah, that is what is shown in this figure:

image

msoroush commented 5 years ago

This is the my vapor density data for TraPPE. This difference is not visible when you plot the density. vap

msoroush commented 5 years ago

This data for one replica must have better quality.Can you use this data for TAMie to compare with their data?

VLE_10A_TAMie.tar.gz

msoroush commented 5 years ago

@ramess101

If you are looking for Keasler uncertainties in VLE data, here is the link for it.

ramess101 commented 5 years ago

@msoroush

Where did you get the "GOMC" values for the figure you plotted above? Was that from recent simulations? I think if you convert that to a percent deviation plot you are going to see a similar discrepancy because the green points appear to be slightly shifted (on a log plot).

ramess101 commented 5 years ago

@msoroush

Thanks for directing me to Keasler uncertainties. They weren't reported in the original manuscript, but I didn't think to look on the website.

msoroush commented 5 years ago

@ramess101 I ran it before, when I was trying to find the problem with torsion.

ramess101 commented 5 years ago

@msoroush

OK, but do you agree that there is also a small shift in vapor density? If you have the data, I could throw it on a deviation plot to see if it really does deviate slightly

msoroush commented 5 years ago

@ramess101 I totally agreeing with you. I can see the deviation, but when you calculate the error, you can see it more clearly. Lets see how TAMie results looks like. One other thing I found out, in their paper, they mentioned that they used tabulated parameter for TAMie and used reservoir method for molecule insertion/deletion.

ramess101 commented 5 years ago

@msoroush

Cool, just wanted to make sure we were on the same page. Here are the TAMie results with the updated values you uploaded:

image

ramess101 commented 5 years ago

@msoroush

On Towhee and GROMACS I have always obtained consistent results for tabulated or native LJ potentials, but I guess it could impact your results if the spacing is not refined.

ramess101 commented 5 years ago

@msoroush

Here I have replotted the Keasler comparison with the uncertainties:

image

msoroush commented 5 years ago

@msoroush

Here I have replotted the Keasler comparison with the uncertainties:

image

Our data are between Keasler and Yiann, data :D

ramess101 commented 5 years ago

@msoroush

It is curious that our rhol and DeltaHv are much lower for TraPPE, while our rhol is higher and DeltaHv lower for TAMie

ramess101 commented 5 years ago

@msoroush

So do we anticipate having results by Monday for TAMie with 10 A cut-off and maybe 14 A?

msoroush commented 5 years ago

@ramess101 Hopefully they both will be finished by tomorrow. As soon as I get the results. I will send it to you.

ramess101 commented 5 years ago

@msoroush

Alright sounds good. Thanks again!

ramess101 commented 5 years ago

@msoroush @jpotoff

I think we need to anticipate that our TAMie results are going to have slight (but irreconcilable) deviations from Weidler et al. How do we want to address this in the manuscript/review? The deviations in DeltaHv are particularly concerning since the reviewer claims that our approach will suffer from finite-size effects (although our comparison for system sizes didn't seem to suggest that was true).

msoroush commented 5 years ago

@ramess101 we tried their method to calculate the dHv. Results where changed slightly for molecules with intrabonded energy, which would result in change in the error value. Maybe we can calculate dHV with their method, and plot them together to see if the dHv for cyclohexane changes or not.

ramess101 commented 5 years ago

@msoroush

OK, that might be the cause of the discrepancy. We assume that intrabonded is the same in liquid and vapor phase right? This certainly could contribute around 1% to dHv. Do you have those dHv values readily available?

jpotoff commented 5 years ago

The TAMie method for calculating heat of vaporization appears to be more resistant to finite size effects in the near critical region. It doesn't seem to offer better performance with respect to finite size effects at lower temperatures. We did see a small shift in the calculated error going from our method to the TAMie way of doing things. It might be due to the bonded interactions, but we don't have conclusive evidence, yet. @msoroush Could you post Niloo's figures for methane and butane to illustrate the difference? The only way to really tell would be to compare to GEMC simulations where we calculate dHv using bonded and non-bonded interactions. Unfortunately, the uncertainty in those data is a lot larger than the GCMC results...

ramess101 commented 5 years ago

@jpotoff @msoroush

OK, so the difference at low T is not due to finite size effects. But it could be caused by how dHv is being computed, namely, their approach makes no assumption about intramolecular energies cancelling between the two phases.

Yeah, the fact that there might be some discrepancy between GEMC and GCMC is not totally unexpected. I don't think we need to run GEMC simulations for this study, although it could be worth looking into.

For the purpose of this review, we just need to show that the deviation in TAMie is: 1) Not due to finite-size effects 2) Caused by different analysis methods, where our approach assumes intramolecular energies are the same in vapor and liquid. Right?

msoroush commented 5 years ago

@ramess101 @jpotoff Butane: butane-averages

Methane: methane-averages

ramess101 commented 5 years ago

@msoroush

So the left panels use our method and the right panels is TAMie method? Discrepancy in methods appear larger for butane, supporting the intramolecular theory

On Friday, March 8, 2019, Mohammad Soroush Barhaghi < notifications@github.com> wrote:

Butane: [image: butane-averages] https://user-images.githubusercontent.com/13317444/54060637-7b0b1080-41cb-11e9-8614-97a3e9404bf5.png

Methane: [image: methane-averages] https://user-images.githubusercontent.com/13317444/54060669-96761b80-41cb-11e9-96aa-106418e94a91.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramess101/JCED_FOMMS_Manuscript/issues/26#issuecomment-471105175, or mute the thread https://github.com/notifications/unsubscribe-auth/AWUvhBUFatDs7AKMy4YU_i9tx9E3Jh07ks5vUurXgaJpZM4bSc9v .

msoroush commented 5 years ago

@ramess101

Here are the results for rcut10 and 14 for TAMie rcut10.zip rcut14.zip

ramess101 commented 5 years ago

@msoroush

The rcut14 looked marginally better, and I think we should include the rcut14 results. The rcut14.zip folder was missing the Average_Results_m1.dat file. Could you re-zip rcut14 with this file and re-upload it?

msoroush commented 5 years ago

@ramess101 Here are the average results rcut14.zip

ramess101 commented 5 years ago

@msoroush @jpotoff

OK, here are the comparisons for our TAMie simulations:

rcut = 10 A

image

rcut = 14 A

image

ramess101 commented 5 years ago

@msoroush @jpotoff

rcut = 14 A is slightly better, but still a clear discrepancy.

Is this unexpected? Of course our DeltaHv analysis is different, but would you expect the disagreement for rholiq and Psat? Could the difference in Psat be related to the different approaches for computing absolute pressures (recall Issue #29)? But this shouldn't affect rholiq, right? Because equating the pressures in the two phases should still be the same.

Instead, could the difference in rholiq be related to how the reweighting scheme only includes the non-bonded energies? In other words, would the phase equilibria change some if the histograms used the total energy (with intramolecular)?

ramess101 commented 5 years ago

@msoroush @jpotoff

In case you didn't know, the response to the reviewer comments is due today. I think this is really the only issue that we still need to resolve. Please let me know if you have any thoughts for how we can adequately explain the discrepancy between our TAMie results.

ramess101 commented 5 years ago

@msoroush

Would you be able to compute DeltaHv for our TAMie simulations (14 A) using the TAMie methodology? Including those values might be helpful.

jpotoff commented 5 years ago

The agreement for rho_liquid and dHv, is reasonably decent; at least we have overlap of the error bars. It's the vapor density and vapor pressure that are way off. Given that the vapor densities are different, the difference in the vapor pressure is unlikely to be due to the different techniques used to get the reference state. Without seeing their simulation and histogram analysis code, it is impossible to explain why the results are different with any certainty.

Looking at Gross's data, if those were our data, I would concerned about the large error bars, especially near the critical point. That seems very odd.

ramess101 commented 5 years ago

@jpotoff

Good point about the vapor densities. I will plot up the Zvap really quick to see what those look like.

ramess101 commented 5 years ago

@jpotoff

However, the rholiq deviations are actually not within the error bars at most temperatures (compare "TAMie, This Work" with "TAMie, Weidler et al." DeltaHv are closer though

jpotoff commented 5 years ago

However, the rholiq deviations are actually not within the error bars at most temperatures (compare "TAMie, This Work" with "TAMie, Weidler et al." DeltaHv are closer though

Right. I was incorrectly comparing our results and TAMie instead of comparing TAMie (us) with TAMie (published). We may just have to throw our hands up on this one since the TAMie calculations are done with a non-open source simulation engine.

ramess101 commented 5 years ago

@jpotoff

Yeah, currently I just try to pass this off as relatively small deviations for rhol and DeltaHv (less than 0.5%)

ramess101 commented 5 years ago

@msoroush @jpotoff

Here is a comparison for the Zvap values:

image

I think this shows that the deviation in Psat is due to the deviations in rhovap because we get the same Z, right?

jpotoff commented 5 years ago

I think my brain just exploded. Pvap and rho_vap are different between our results and Gross, but we get cancellation of errors to give an exact match for Z=PV_gas/RT? I'm having a hard time reconciling these results.

ramess101 commented 5 years ago

@jpotoff

My mindset was that this demonstrates that the ideal gas is not to blame for the discrepancy in Psat. Because we still get Z converging to 1, the pressure calculations are consistent with the densities, right?

msoroush commented 5 years ago

@ramess101 What if we plot error in Z? I think we will see some deviation.

ramess101 commented 5 years ago

@msoroush

Yeah, but we can tell that the error bars do overlap. Of course, the Z error bars might be too large since I assumed independence between rhovap and Psat...let me fix that first

I can't do anything about how the error bars are reported for Weidler. I could do it rigorously for the 20 replicates, but it might not be worth my time.

ramess101 commented 5 years ago

@msoroush @jpotoff

image

jpotoff commented 5 years ago

That resolves the comment about reference states.

Still having a hard time resolving that rho_vap and Pvap don't agree with us. I guess we have to accept that we aren't going to be able to answer that question conclusively. Then again, we weren't asked to do that by the reviewers. If we stick with just Z and put the plot in the supporting info, or in the response to the reviewers, that should be sufficient.

ramess101 commented 5 years ago

@jpotoff

Agreed.

ramess101 commented 5 years ago

@msoroush @jpotoff

This is actually in response to comment #28 Any suggestions or concerns for this portion of the response:

image

image

image

jpotoff commented 5 years ago

This looks good. We've gone above and beyond addressing the reviewer comments.

ramess101 commented 5 years ago

@jpotoff

Thanks, agreed!

On Monday, March 11, 2019, Jeffrey Potoff notifications@github.com wrote:

This looks good. We've gone above and beyond addressing the reviewer comments.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramess101/JCED_FOMMS_Manuscript/issues/26#issuecomment-471752488, or mute the thread https://github.com/notifications/unsubscribe-auth/AWUvhJWjtUUWauT2kyNpnHBseiPJM1ZKks5vVtFbgaJpZM4bSc9v .

ramess101 commented 5 years ago

@msoroush

Do you have the state points (chemical potentials) that you used to simulate TAMie (just for 3.5 nm box and 1.4 nm cutoff simulations)? Just needed for the SI

On Monday, March 11, 2019, Richard Messerly ramess101@gmail.com wrote:

@jpotoff

Thanks, agreed!

On Monday, March 11, 2019, Jeffrey Potoff notifications@github.com wrote:

This looks good. We've gone above and beyond addressing the reviewer comments.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramess101/JCED_FOMMS_Manuscript/issues/26#issuecomment-471752488, or mute the thread https://github.com/notifications/unsubscribe-auth/AWUvhJWjtUUWauT2kyNpnHBseiPJM1ZKks5vVtFbgaJpZM4bSc9v .

msoroush commented 5 years ago

@ramess101 Here are the state point for TAMie

RUNS
===============================================
-   #    T(K)      Chem. Pot   CBMC_LJ_1st CBMC_LJ_nth
-----------------------------------------------------------
R   1    450        -4358       8          4
R   2    510        -4358       8          4
R   3    550        -4358       8          4
R   4    510        -4165       8          4
R   5    470        -4036       8          4
R   6    430        -3923       16        10
R   7    400        -3852       16        10
R   8    370        -3793       16        10
R   9    350        -3762       16        10
ramess101 commented 5 years ago

@msoroush

Perfect

On Monday, March 11, 2019, Mohammad Soroush Barhaghi < notifications@github.com> wrote:

@ramess101 https://github.com/ramess101 Here are the state point for TAMie

RUNS

  • T(K) Chem. Pot CBMC_LJ_1st CBMC_LJ_nth


    R 1 450 -4358 8 4 R 2 510 -4358 8 4 R 3 550 -4358 8 4 R 4 510 -4165 8 4 R 5 470 -4036 8 4 R 6 430 -3923 16 10 R 7 400 -3852 16 10 R 8 370 -3793 16 10 R 9 350 -3762 16 10

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ramess101/JCED_FOMMS_Manuscript/issues/26#issuecomment-471770911, or mute the thread https://github.com/notifications/unsubscribe-auth/AWUvhB_JYiIv87GPTcgUfmbO_9bFIIYTks5vVt1agaJpZM4bSc9v .