Open ramess101 opened 5 years ago
@ramess101 I'm not eager to change how we calculate dHv for this paper. What they propose may be better, but as you mentioned, it's inconsistent with how we calculated dHv in the past, and it's going to throw off the validation of MBAR and confuse people. The paper is not about system size effects (we are writing another paper on that, btw), and the data show reasonably small system size effects except in the near critical region, anyway. Using this other method is not going to produce substantially different results, nor would it change the optimal parameters, since the scoring function is designed to focus primarily on liquid density and vapor pressure.
That said, we could try it on the cyclohexane data and see what we get. Not opposed to using this method in the future, but I think it's not a good idea to change it for this paper.
@jpotoff
I'm not eager to change how we calculate dHv for this paper. What they propose may be better, but as you mentioned, it's inconsistent with how we calculated dHv in the past, and it's going to throw off the validation of MBAR and confuse people.
I agree.
The paper is not about system size effects (we are writing another paper on that, btw), and the data show reasonably small system size effects except in the near critical region, anyway.
To satisfy this reviewer we can also mention the finite-size effects investigation we performed for cyclohexane.
Using this other method is not going to produce substantially different results, nor would it change the optimal parameters, since the scoring function is designed to focus primarily on liquid density and vapor pressure.
For example, we still got essentially the same optimal as the TAMie force field that was optimized using the alternative method.
That said, we could try it on the cyclohexane data and see what we get. Not opposed to using this method in the future, but I think it's not a good idea to change it for this paper.
I think we leave this approach to future studies if we find it to be necessary.
@mrshirts @jpotoff @msoroush
My response:
@ramess101 @jpotoff Here are the results for calculating the dHV using GCMC + HR (dHv, blue), Weidler and Gross (dHv2, red), and GEMC (green). There are good agreements in high temperature for all 3 methods, but at low temperature, Weidler and Gross deviates by ~0.6 kcal/mol. I attached the results for you.
@msoroush
Very interesting. This seems to suggest that our approach is actually better than Weidler and Gross against finite-size effects at low T. I guess, is it possible GEMC has finite-size effects for such low densities in the vapor phase at low T?
@ramess101 I have around 160 molecule in my gas phase. Usually GEMC shows finite size effect near critical points. Have you tried to apply the Weidler and Gross for cyclohexane results?
@msoroush
Yeah, I have never seen traditional finite-size effects in GEMC at low T. But if N = 0 in the vapor phase it could be a similar problem to GCMC with poor averaging. This could also come back to the discussion we had previously about
I haven't applied their approach.
Just following up on this because we have some new data. If one calculates the d ln p/d (1/T) at each temperature of interest, no significant difference is observed between the two methods.
@mrshirts @jpotoff @msoroush
Here is Eq 17:
Here is what Weidler and Gross stated:
I don't think we want to change how we compute DeltaHv for two reasons. First, this will mess up the validation comparison with GCMC-HR (Figures 1 and 3). Second, the individualized optimizations (Figure 2) will be inconsistent with the original MiPPE parameterization (for branched alkanes only since alkynes do not include DeltaHv). We could modify the approach for the cyclohexane optimization, but I think this will only confuse the reader to have two DeltaHv approaches. @jpotoff @msoroush what are your thoughts?