search

ramhiser / sparsediscrim

Sparse and Regularized Discriminant Analysis in R
Other
15 stars 5 forks source link

Predict functions should return factors #3

Closed ramhiser closed 12 years ago

ramhiser commented 13 years ago

I noticed that when dlda() is called and then a predict call is made that a vector of strings is returned. Returning a vector of factors is preferred. I'm not sure if classifiers other than dlda() are missing this feature, but need to double-check.

Write a unit test for each classifier to guarantee this.

ramhiser commented 13 years ago

I have added this feature to each of the five diagonal classifiers.

ramhiser commented 13 years ago

Still need to write unit test for this.