ramiboutas / nicecv

Source code of the Nice CV web application
https://nicecv.online
7 stars 0 forks source link

Collected Feedback comments #15

Open ramiboutas opened 9 months ago

ramiboutas commented 9 months ago

More:

ramiboutas commented 9 months ago
ramiboutas commented 9 months ago

Hola Rami, he visitado el enlace desde el móvil y inicialmente toma mucho tiempo y dice “Bad Gateway”. Después de varios intentos y copiando el enlace en safari, así se ve:

image

ramiboutas commented 9 months ago

I’d avoid using floats for currency. Better to use decimals. Your KeyError may catch more than intended. Look before you leap may be more appropriate here.

image

ramiboutas commented 9 months ago

image

ramiboutas commented 9 months ago

I'd use different phrasing instead of "buy plan". Just use the phrase "buy" instead. image

ramiboutas commented 9 months ago

I have a comment not related to your question. I see you're storing current language settings into cookie. While this might be easier for you to handle multilanguage, search engine crawlers will not be able to index pages other than english. They don't use cookies. You will need language info in urls for crawlers. Django have great out-of-box support for multilanguage urls.

https://www.facebook.com/groups/2310400015870119/posts/3594344414142333/?comment_id=3594682174108557&notif_id=1704550900376970&notif_t=group_comment

ramiboutas commented 9 months ago

Hi, when the amount is converted to euro’s I’m missing the decimal comma in the localization which in my case is NL/dutch. Perhaps you can also add a functionality based on the actual location where the user resides to show that currency. For me that is the USD.