search

ramiismail / dopresskit

presskit() - spend time making games, not press.
GNU General Public License v3.0
137 stars 50 forks source link

Incorrect link names in additionals #70

Open dersnek opened 5 years ago

dersnek commented 5 years ago

Filling additionals menu as in manual, shows link names as "http:" instead of domain name.

Code in data.xml:

<additional>
    <title>Katata Blog</title>
    <description>We're keeping a record of our struggles as game developers</description>
    <link>http://katatagames.com/category/blog</link>
</additional>

Expected result: We're keeping a record of our struggles as game developers katatagames.com. (where "katatagames.com" is a link to http://katatagames.com/category/blog)

Actual result: We're keeping a record of our struggles as game developers http:. (where "http:" is a link to http://katatagames.com/category/blog)

Examples: http://katatagames.com/press/ https://www.vlambeer.com/press/

Examples without bug: http://younghorsesgames.com/press/sheet.php?p=octodad_dadliest_catch http://press.headbang.club/sheet.php?p=double_kick_heroes

mbndr commented 5 years ago

I guess you have to fix the bug yourself because this repository seems abandoned (last commit 2014). The error has to be somewhere around here or more likely here.

If you want (and are a bit experienced in Go compiling) you could also check out my Go rewrite where I can help you more. (https://github.com/mbndr/gopresskit)

dersnek commented 5 years ago

I guess you have to fix the bug yourself because this repository seems abandoned (last commit 2014). The error has to be somewhere around here or more likely here.

If you want (and are a bit experienced in Go compiling) you could also check out my Go rewrite where I can help you more. (https://github.com/mbndr/gopresskit)

Should've thought about that. Thanks, I'll try to fix it or I'll try your rewrite. I'm not experienced in Go compiling but maybe it's time to give it a try.

qulien commented 2 years ago

Link handling is an inconsistent, buggy mess. It really is. Sometimes "http://" will be added. Sometimes not. Sometimes a "/" gets added at the end. Or removed from the end. Sometimes not.

This inconsistency shows in obvious ways, for example the broken link text you found. But it also shows in other, less visible places. For example, you can see on the Vlambeer example presskit page that the company link in the "Factsheet" section actually looks like this (note the double "https://"):

<a href="http://http://www.vlambeer.com">http://www.vlambeer.com</a>