Closed Dearon closed 10 years ago
ramiismail
commented
10 years ago I haven't heard of Flight before, but I think the idea is to keep the code as accessible as possible without learning anything beyond basic PHP. While I'm sure Flight is beneficial to the structure, I'm not sure it doesn't impact the hackability of the project for people with no PHP experience. Even though hacking the project for personal needs is discouraged subtly, I don't want to throw up actual technical hurdles.
Dearon
commented
10 years ago It'll increase the technical skill needed a little, but as this learn page shows Flight is very small in the functions it offers. So I don't think it will become harder to work with overall than it is now.
That is, right now there are a few files which are 500+ lines long so working through them present their own challenges. With Flight that could hopefully be reduced somewhat but with a handful of functions from Flight thrown in here and there like routing and views. In my opinion those few options will be easy enough to understand for most people, and they will rarely need to be changed anyway (much like you're not going to rename sheet.php right now).
Dearon
commented
10 years ago @ramiismail bump (not gonna do anything on this issue until you give up thumbs up due to the amount of work involved :p)
ramiismail
commented
10 years ago I think I'd rather leave this one out for now, although I might at some point reconsider. Is that OK?
On Tue, Dec 24, 2013 at 2:21 PM, Dearon notifications@github.com wrote:
@ramiismail https://github.com/ramiismail bump (not gonna do anything on this issue until you give up thumbs up due to the amount of work involved :p)
— Reply to this email directly or view it on GitHubhttps://github.com/ramiismail/dopresskit/issues/9#issuecomment-31171341 .
@ramiismail How do you feel about porting the code to use Flight so that we can more easily create clean urls and use views?
It will add some extra files to the project and entail some big changes to the code, but I think it should be very do-able to keep everything compatible, to keep a working install.php and to make everything much easier to maintain in the long run (especially for people who aren't familiar with the codebase). So what do you think?