search

raml-org / raml-js-parser

(deprecated) A RAML parser based on PyYAML written in CoffeScript and available for use as NodeJs module or in-browser.
195 stars 53 forks source link

Features/dereferencing support with circular references #180

Closed repocho closed 8 years ago

repocho commented 8 years ago

Fixes #179

Finally I limited the circular references up to 500 by default which in my case is not throwing errors.

If there is a harder limit of nodejs you can set the maxDepth like this example:

raml.loadFile('raml-files/circular.raml', { dereferenceSchemas: { maxDepth: 25} })

repocho commented 8 years ago

I've updated the travis nodejs version to the latest LTS version 4.4.4

repocho commented 8 years ago

@dmartinezg Travis is failing because the used version of phantomjs does not allow Object.assign. Should I update the grunt-mocha-phantomjs to the latest version 3.0.0?

repocho commented 8 years ago

@dmartinezg I updated grunt-mocha-phantomjs library but the error was still there due to the limitation of phamtomjs engine with es6 features. Finally I've added a shim library for Object.assign to avoid problems to people using this inside an old browser.

If you have more concerns about this PR please let me know in order to be able to merge it as soon as possible.

Thanks !

dmartinezg commented 8 years ago

Can you squash commits so I can merge from here? I don't want to close this PR and steal your contribution :)

repocho commented 8 years ago

Done ! Thanks.