search

raml-org / raml-tck

Test Compatibility Kit for RAML 1.0
http://raml-org.github.io/raml-tck/
8 stars 10 forks source link

Fix protocols to match RAML 0.8 output #15

Closed xaka closed 8 years ago

xaka commented 8 years ago

RAML 0.8 (uppercase):

  "protocols": [
    "HTTPS"
  ],

RAML 1.0:

  "protocols": [
    "https"
  ],
sichvoge commented 8 years ago

I think that is rather obsolete as the spec clearly says that the value of a protocol node is case-insensitive. So the example above could be valid.

But that, of course, depends on if you use the same example in your case and the raml2json returns you these two different outputs?

blakeembrey commented 8 years ago

@sichvoge It also depends on whether the JSON we receive is considered normalized. Considering that all the metadata is being added to populate things, it's already being normalized - so I'd expect that little things like this could be handled too.

sichvoge commented 8 years ago

Agree! @KonstantinSviridov we should return a consistent representation.

KonstantinSviridov commented 8 years ago

Guys, I do not quite understand, what you've finally decided. Do we convert protocols values to upper case or not?

blakeembrey commented 8 years ago

I don't care either way, it really comes down to @xaka and if (or how much) we want to improve the representation output for the new parser development. I've noticed this with some other issues opened on diffs between 0.8 and 1.0 parser output and I feel we could improve the output slightly over both while understanding the changes.

However, for consistency, let's use 0.8 output here.

sichvoge commented 8 years ago

However, for consistency, let's use 0.8 output here.

LGTM :+1:

KonstantinSviridov commented 8 years ago

Ok. In the intermediate parser it's already implemented in 0.8 output style.